OpenStack Compute (nova)

BuildRequest ovo incorrectly assumes that IncompatibleObjectVersion exception has an objver field

  1. Series queens
  2. Bug #1812177
Bug #1812177 reported by Balazs Gibizer
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Balazs Gibizer
Ocata
Fix Committed
Low
Matt Riedemann
Pike
Fix Committed
Low
Elod Illes
Queens
Fix Committed
Low
Elod Illes
Rocky
Fix Released
Low
Elod Illes

Bug Description

BuildRequest ovo incorrectly assumes that IncompatibleObjectVersion exception has an objver field while handling such exception. This leads to an AttributeError during exception handling in [1].

[1] https://github.com/openstack/nova/blob/e3b517b6fd7c470d5cee420fce1456b98495d310/nova/objects/build_request.py#L83

OpenStack Infra (hudson-openstack)
Changed in nova:
assignee: nobody → Balazs Gibizer (balazs-gibizer)
status: New → In Progress
Balazs Gibizer (balazs-gibizer)
Changed in nova:
importance: Undecided → Low
tags: added: conductor
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/631179
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=975f0156137e37f7a9139c0268547d79dcc3c43c
Submitter: Zuul
Branch: master

commit 975f0156137e37f7a9139c0268547d79dcc3c43c
Author: Balazs Gibizer <email address hidden>
Date: Wed Jan 16 10:57:07 2019 +0100

    Fix incompatible version handling in BuildRequest

    The BuildRequest object code assumed that IncompatibleObjectVersion
    exception has a objver field that contains the object version. This
    assumption is not true. The unit test made another mistake serializing
    the function object obj_to_primitive instead of serializing the result
    of the call of obj_to_primitive. This caused a false positive test
    covering the error in the implementation as well.

    Closes-Bug: #1812177

    Change-Id: I1ef4a23aa2bf5cb46b481045f3d968f62f74606d

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/631731

Elod Illes (elod-illes)
no longer affects: ubuntu
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/rocky)

Reviewed: https://review.openstack.org/631731
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=6061186d2d86eb628dcdc61667c240576fa8f10e
Submitter: Zuul
Branch: stable/rocky

commit 6061186d2d86eb628dcdc61667c240576fa8f10e
Author: Balazs Gibizer <email address hidden>
Date: Wed Jan 16 10:57:07 2019 +0100

    Fix incompatible version handling in BuildRequest

    The BuildRequest object code assumed that IncompatibleObjectVersion
    exception has a objver field that contains the object version. This
    assumption is not true. The unit test made another mistake serializing
    the function object obj_to_primitive instead of serializing the result
    of the call of obj_to_primitive. This caused a false positive test
    covering the error in the implementation as well.

    Closes-Bug: #1812177

    Change-Id: I1ef4a23aa2bf5cb46b481045f3d968f62f74606d
    (cherry picked from commit 975f0156137e37f7a9139c0268547d79dcc3c43c)

tags: added: in-stable-rocky
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/634439

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/queens)

Reviewed: https://review.openstack.org/634439
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=7c85ebad0bf13d609b384e7637b0787bf8d484f7
Submitter: Zuul
Branch: stable/queens

commit 7c85ebad0bf13d609b384e7637b0787bf8d484f7
Author: Balazs Gibizer <email address hidden>
Date: Wed Jan 16 10:57:07 2019 +0100

    Fix incompatible version handling in BuildRequest

    The BuildRequest object code assumed that IncompatibleObjectVersion
    exception has a objver field that contains the object version. This
    assumption is not true. The unit test made another mistake serializing
    the function object obj_to_primitive instead of serializing the result
    of the call of obj_to_primitive. This caused a false positive test
    covering the error in the implementation as well.

    Closes-Bug: #1812177

    Change-Id: I1ef4a23aa2bf5cb46b481045f3d968f62f74606d
    (cherry picked from commit 975f0156137e37f7a9139c0268547d79dcc3c43c)
    (cherry picked from commit 6061186d2d86eb628dcdc61667c240576fa8f10e)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 19.0.0.0rc1

This issue was fixed in the openstack/nova 19.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 17.0.10

This issue was fixed in the openstack/nova 17.0.10 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 18.2.0

This issue was fixed in the openstack/nova 18.2.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/647557

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/pike)

Reviewed: https://review.openstack.org/647557
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=ebf011f11ebb4d329e90e7ec0e498a3a6832e154
Submitter: Zuul
Branch: stable/pike

commit ebf011f11ebb4d329e90e7ec0e498a3a6832e154
Author: Balazs Gibizer <email address hidden>
Date: Wed Jan 16 10:57:07 2019 +0100

    Fix incompatible version handling in BuildRequest

    The BuildRequest object code assumed that IncompatibleObjectVersion
    exception has a objver field that contains the object version. This
    assumption is not true. The unit test made another mistake serializing
    the function object obj_to_primitive instead of serializing the result
    of the call of obj_to_primitive. This caused a false positive test
    covering the error in the implementation as well.

    Conflicts:
        nova/objects/build_request.py

    Note(elod.illes): conflict is due to not having patch
    Ie3a83fef0dc689b9d37ac43e047ce5d48f567adc on stable/pike.

    Closes-Bug: #1812177

    Change-Id: I1ef4a23aa2bf5cb46b481045f3d968f62f74606d
    (cherry picked from commit 975f0156137e37f7a9139c0268547d79dcc3c43c)
    (cherry picked from commit 6061186d2d86eb628dcdc61667c240576fa8f10e)
    (cherry picked from commit 7c85ebad0bf13d609b384e7637b0787bf8d484f7)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 16.1.8

This issue was fixed in the openstack/nova 16.1.8 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.opendev.org/660456

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/ocata)

Reviewed: https://review.opendev.org/660456
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=8a20b086a14dd73bfa57cdef632a28e72e265eb2
Submitter: Zuul
Branch: stable/ocata

commit 8a20b086a14dd73bfa57cdef632a28e72e265eb2
Author: Balazs Gibizer <email address hidden>
Date: Wed Jan 16 10:57:07 2019 +0100

    Fix incompatible version handling in BuildRequest

    The BuildRequest object code assumed that IncompatibleObjectVersion
    exception has a objver field that contains the object version. This
    assumption is not true. The unit test made another mistake serializing
    the function object obj_to_primitive instead of serializing the result
    of the call of obj_to_primitive. This caused a false positive test
    covering the error in the implementation as well.

    Closes-Bug: #1812177

    Change-Id: I1ef4a23aa2bf5cb46b481045f3d968f62f74606d
    (cherry picked from commit 975f0156137e37f7a9139c0268547d79dcc3c43c)
    (cherry picked from commit 6061186d2d86eb628dcdc61667c240576fa8f10e)
    (cherry picked from commit 7c85ebad0bf13d609b384e7637b0787bf8d484f7)
    (cherry picked from commit ebf011f11ebb4d329e90e7ec0e498a3a6832e154)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova ocata-eol

This issue was fixed in the openstack/nova ocata-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.