nova send None global_request_id on neutron calls

[Zhang Shuaiyi]

I config logging_context_format_string in cinder.conf, neutron.conf and nova.conf。
[default]
logging_context_format_string=%(asctime)s.%(msecs)03d %(process)d %(levelname)s %(name)s [%(global_request_id)s %(request_id)s %(user_identity)s] %(instance)s%(message)s

After boot a new instance, I get the request_id of the nova request which is req-3acf5bf3-3fcb-40c7-b9f2-3a96947836cc.

[root@shyiq ~(keystone_admin)]# openstack server event list 96e0c916-0ca9-4b35-9663-3129944d7e81
+------------------------------------------+--------------------------------------+--------+----------------------------+
| Request ID | Server ID | Action | Start Time |
+------------------------------------------+--------------------------------------+--------+----------------------------+
| req-3acf5bf3-3fcb-40c7-b9f2-3a96947836cc | 96e0c916-0ca9-4b35-9663-3129944d7e81 | create | 2018-12-28T02:04:35.000000 |
+------------------------------------------+--------------------------------------+--------+----------------------------+

I can find req-3acf5bf3-3fcb-40c7-b9f2-3a96947836cc as global_request_id in /var/log/nova/nova-placement-api.log and /var/log/cinder/api.log, but None in /var/log/neutron/server.log。

Nova send request_id to glance, cinder and neutron in the following Change-Id
Ic5ee9161cd1174a2dd32b7f155194a7110cc5219
I16f9dda3c904c4a2578fa6a691fed646a41f6793
I866b8c6593c76c089da6bed55cf863ac556c9a8e
But since I41724a612a5f3eabd504f3eaa9d2f9d141ca3f69 nova send context.global_request_id which may be None on neutron calls.

stable/rocky and stable/queens also have this bug.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/627603

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/627604

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/627034
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=a31157c527ae88af2e8c283e8b5156e9ace55dfa
Submitter: Zuul
Branch: master

commit a31157c527ae88af2e8c283e8b5156e9ace55dfa
Author: ZhangShuaiyi <email address hidden>
Date: Sat Dec 22 16:33:26 2018 +0800

    Send context.global_id on neutron calls

    In I866b8c6593c76c089da6bed55cf863ac556c9a8e nova sends global_id
    on neutron calls, but in I41724a612a5f3eabd504f3eaa9d2f9d141ca3f69
    it changed to global_request_id which may be None.

    A simple unit test wrinkle is added to avoid future regressions.

    Closes-Bug:#1809943

    Change-Id: Iaa47304755db66a834dde38dcd55cc259c1008a3

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/627603
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=6e1120ae3025a532ff8957a6952f445152a69967
Submitter: Zuul
Branch: stable/rocky

commit 6e1120ae3025a532ff8957a6952f445152a69967
Author: ZhangShuaiyi <email address hidden>
Date: Sat Dec 22 16:33:26 2018 +0800

    Send context.global_id on neutron calls

    In I866b8c6593c76c089da6bed55cf863ac556c9a8e nova sends global_id
    on neutron calls, but in I41724a612a5f3eabd504f3eaa9d2f9d141ca3f69
    it changed to global_request_id which may be None.

    A simple unit test wrinkle is added to avoid future regressions.

    Closes-Bug:#1809943

    Change-Id: Iaa47304755db66a834dde38dcd55cc259c1008a3
    (cherry picked from commit a31157c527ae88af2e8c283e8b5156e9ace55dfa)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/627604
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=dcd7a30c9548512eaee91b96d0ed0f4b18bcdbff
Submitter: Zuul
Branch: stable/queens

commit dcd7a30c9548512eaee91b96d0ed0f4b18bcdbff
Author: ZhangShuaiyi <email address hidden>
Date: Sat Dec 22 16:33:26 2018 +0800

    Send context.global_id on neutron calls

    In I866b8c6593c76c089da6bed55cf863ac556c9a8e nova sends global_id
    on neutron calls, but in I41724a612a5f3eabd504f3eaa9d2f9d141ca3f69
    it changed to global_request_id which may be None.

    A simple unit test wrinkle is added to avoid future regressions.

    Closes-Bug:#1809943

    Change-Id: Iaa47304755db66a834dde38dcd55cc259c1008a3
    (cherry picked from commit a31157c527ae88af2e8c283e8b5156e9ace55dfa)
    (cherry picked from commit 6e1120ae3025a532ff8957a6952f445152a69967)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 19.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 17.0.10 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 18.2.0 release.