Consumers with no allocations should be auto-deleted

[Jay Pipes]

When an allocation is POST'd or PUT'd and the set of allocations for a consumer is deleted (indicated with an empty dict for the allocations), then the consumer should be automatically deleted.

[Matt Riedemann (mriedem)]

Presumably (obviously) this also includes DELETE /allocations/{consumer_id}

https://developer.openstack.org/api-ref/placement/#delete-allocations

[Matt Riedemann (mriedem)]

I don't think this is really high severity, I'd consider it medium or low. The stale consumer records don't really hurt anything, and they'd get used again later if that consumer has new allocations.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/581086
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=f0f680b492c82f4f5c4163b0534dacc315b6dce5
Submitter: Zuul
Branch: master

commit f0f680b492c82f4f5c4163b0534dacc315b6dce5
Author: Jay Pipes <email address hidden>
Date: Mon Jul 9 12:41:05 2018 -0400

    delete consumers which no longer have allocations

    We made the decision [1] to delete consumer records when those consumers
    no longer had any allocations referring to them (as opposed to keeping
    those consumer records around and incrementing the consumer generation
    for them).

    This patch adds a small check within the larger
    AllocationList.create_all() and AllocationList.delete_all() DB
    transactions that deletes consumer records when no allocation records
    remain that reference that consumer. This patch does not, however,
    attempt to clean up any "orphaned" consumer records that may have been
    created in previous calls to PUT|POST /allocations that removed the last
    remaining allocations for a consumer.

    [1] https://goo.gl/DpAGbW

    Change-Id: Ic2b82146d28be64b363b0b8e2e8d180b515bc0a0
    Closes-bug: #1780799

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 18.0.0.0b3 development milestone.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/697398

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Elod Illes <email address hidden>" on branch: stable/queens
Review: https://review.opendev.org/c/openstack/nova/+/697398
Reason: This branch transitioned to End of Life for this project, open patches needs to be closed to be able to delete the branch.