VMware: _detach_instance_volumes method fails due to wrong detach_volume call

Bug #1759609 reported by Claudiu Belu
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
High
Claudiu Belu
Queens
Fix Committed
High
Claudiu Belu

Bug Description

The method _detach_instance_volumes [1] calls self.detach_volume [2] with an invalid number of arguments (context argument is missing), causing it to fail.

[1] https://github.com/openstack/nova/blob/master/nova/virt/vmwareapi/driver.py#L426
[2] https://github.com/openstack/nova/blob/master/nova/virt/vmwareapi/driver.py#L438

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/557377

Changed in nova:
assignee: nobody → Claudiu Belu (cbelu)
status: New → In Progress
Matt Riedemann (mriedem)
tags: added: vmware volumes
Claudiu Belu (cbelu)
tags: added: queens-backport-potential
melanie witt (melwitt)
Changed in nova:
importance: Undecided → Medium
Matt Riedemann (mriedem)
Changed in nova:
importance: Medium → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/557727

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/557377
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=ad4a26e1843bc4cefa2c5b4bb093d692cddfaa49
Submitter: Zuul
Branch: master

commit ad4a26e1843bc4cefa2c5b4bb093d692cddfaa49
Author: Claudiu Belu <email address hidden>
Date: Wed Mar 28 01:36:24 2018 -0700

    vmware: Fixes _detach_instance_volumes method

    The _detach_instance_volumes method calls self.detach_volume with an
    invalid number of arguments (context missing), causing it to fail.
    This patch solves the issue.

    Change-Id: Ibb6afa883c4ed55ea544a1e9d247dab4fc657cd2
    Closes-Bug: #1759609

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/queens)

Reviewed: https://review.openstack.org/557727
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=890b74a0c535870d39881c96aa570258ffc4aa21
Submitter: Zuul
Branch: stable/queens

commit 890b74a0c535870d39881c96aa570258ffc4aa21
Author: Claudiu Belu <email address hidden>
Date: Wed Mar 28 01:36:24 2018 -0700

    vmware: Fixes _detach_instance_volumes method

    The _detach_instance_volumes method calls self.detach_volume with an
    invalid number of arguments (context missing), causing it to fail.
    This patch solves the issue.

    (cherry-picked from commit ad4a26e1843bc4cefa2c5b4bb093d692cddfaa49)

    Change-Id: Ibb6afa883c4ed55ea544a1e9d247dab4fc657cd2
    Closes-Bug: #1759609

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 17.0.2

This issue was fixed in the openstack/nova 17.0.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 18.0.0.0b1

This issue was fixed in the openstack/nova 18.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.