OpenStack Compute (nova)

Wrong assertions in unit tests

Series pike
Bug #1840601

Bug #1840601 reported by Takashi Natsume on 2019-08-19

This bug affects 1 person

	Status	Importance	Assigned to
OpenStack Compute (nova)	Fix Released	Medium	Takashi Natsume
Ocata	In Progress	Medium	Unassigned
Pike	In Progress	Medium	Unassigned
Queens	Fix Committed	Medium	Takashi Natsume
Rocky	Fix Committed	Medium	Takashi Natsume
Stein	Fix Committed	Medium	Takashi Natsume

Bug Description

There are some wrong assertions in unit tests

https://github.com/openstack/nova/blob/ee6b69cadc75219aa53bdb91bb71a8b0cedd215b/nova/tests/unit/virt/vmwareapi/test_vmops.py#L2833
https://github.com/openstack/nova/blob/ee6b69cadc75219aa53bdb91bb71a8b0cedd215b/nova/tests/unit/virt/vmwareapi/test_vmops.py#L2840-L2841
https://github.com/openstack/nova/blob/ee6b69cadc75219aa53bdb91bb71a8b0cedd215b/nova/tests/unit/virt/vmwareapi/test_vmops.py#L2862
https://github.com/openstack/nova/blob/ee6b69cadc75219aa53bdb91bb71a8b0cedd215b/nova/tests/unit/virt/vmwareapi/test_vmops.py#L2868-L2869
https://github.com/openstack/nova/blob/ee6b69cadc75219aa53bdb91bb71a8b0cedd215b/nova/tests/unit/virt/vmwareapi/test_vmops.py#L2940
https://github.com/openstack/nova/blob/ee6b69cadc75219aa53bdb91bb71a8b0cedd215b/nova/tests/unit/virt/vmwareapi/test_vmops.py#L2947-L2948
https://github.com/openstack/nova/blob/ee6b69cadc75219aa53bdb91bb71a8b0cedd215b/nova/tests/unit/virt/ironic/test_driver.py#L1938
https://github.com/openstack/nova/blob/ee6b69cadc75219aa53bdb91bb71a8b0cedd215b/nova/tests/unit/virt/ironic/test_driver.py#L1950

Tags:

Takashi Natsume (natsume-takashi) on 2019-08-19

Changed in nova:
importance:	Undecided → Medium

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-08-19: Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.opendev.org/677102

Changed in nova:
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-08-19: Fix merged to nova (master)

Reviewed: https://review.opendev.org/677102
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=8ea5e373381fc4152d2914742ef42a75acbbcc53
Submitter: Zuul
Branch: master

commit 8ea5e373381fc4152d2914742ef42a75acbbcc53
Author: Takashi NATSUME <email address hidden>
Date: Mon Aug 19 10:13:56 2019 +0900

Fix wrong assertions in unit tests

Change-Id: I54dff4d5ed513690d0fae65de47a1a9c23aebbd4
Closes-Bug: #1840601

Changed in nova:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-08-20: Fix proposed to nova (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/677388

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-08-20: Fix proposed to nova (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/677389

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-08-20: Fix proposed to nova (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/677390

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-08-20: Fix proposed to nova (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.opendev.org/677392

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-08-20: Fix proposed to nova (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.opendev.org/677393

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-09-18: Fix merged to nova (stable/stein)

Reviewed: https://review.opendev.org/677388
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=88b2206f2d2a306280004c5e66c7911bb7b77f58
Submitter: Zuul
Branch: stable/stein

commit 88b2206f2d2a306280004c5e66c7911bb7b77f58
Author: Takashi NATSUME <email address hidden>
Date: Mon Aug 19 10:13:56 2019 +0900

Fix wrong assertions in unit tests

    Change-Id: I54dff4d5ed513690d0fae65de47a1a9c23aebbd4
    Closes-Bug: #1840601
    (cherry picked from commit 8ea5e373381fc4152d2914742ef42a75acbbcc53)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-09-27: Fix included in openstack/nova 20.0.0.0rc1

This issue was fixed in the openstack/nova 20.0.0.0rc1 release candidate.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-09-27: Fix merged to nova (stable/rocky)

#10

Reviewed: https://review.opendev.org/677389
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=331b64a224445ee67426de2f0d508c3ac8561680
Submitter: Zuul
Branch: stable/rocky

commit 331b64a224445ee67426de2f0d508c3ac8561680
Author: Takashi NATSUME <email address hidden>
Date: Mon Aug 19 10:13:56 2019 +0900

Fix wrong assertions in unit tests

    Change-Id: I54dff4d5ed513690d0fae65de47a1a9c23aebbd4
    Closes-Bug: #1840601
    (cherry picked from commit 8ea5e373381fc4152d2914742ef42a75acbbcc53)
    (cherry picked from commit 88b2206f2d2a306280004c5e66c7911bb7b77f58)