Enabling guestfs.debug can hang guestfs.launch
Bug #1737214 reported by
Matt Riedemann
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Compute (nova) |
Fix Released
|
Medium
|
Matt Riedemann | ||
Ocata |
Confirmed
|
Medium
|
Unassigned | ||
Pike |
Fix Committed
|
Medium
|
Matt Riedemann |
Bug Description
I noticed this while debugging this change:
https:/
When we enable guestfs.debug, we're receiving events from guestfs and logging them.
However, guestfs.launch is run in an eventlet thread pool, and running things within an eventlet thread pool for native apps is a no-no for doing logging because it can cause a greenthread switch that makes us lose the return from the guestfs.launch call, which eventually means we hang when trying to create the instance.
So we need to just run guestfs.launch non-threaded if guestfs.debug is enabled.
From the logs, you can see the guestfs.launch thread switch here:
And the logging callback here:
Changed in nova: | |
importance: | High → Medium |
no longer affects: | nova/newton |
To post a comment you must log in.
Fix proposed to branch: master /review. openstack. org/526748
Review: https:/