AllocationCandidates return duplicated allocation requests when no sharing rp

Bug #1709788 reported by Alex Xu
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Alex Xu
Pike
Fix Committed
Medium
Matt Riedemann

Bug Description

The case is: computenode1 and comptuenode3 share the storage from sharedstrorage1, computenode3 has local disk. The expected result from AllocationCandidates is (computenode1, sharedstorage1), (computenode2, sharedstorage1) and (computenode3). But the current return is (computenode1, sharedstorage1), (computenode2, sharedstorage1), (computenode3) and (computenode3), a duplicated (computenodes) returned.

Tags: placement
Alex Xu (xuhj)
Changed in nova:
assignee: nobody → Alex Xu (xuhj)
tags: added: placement
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/492395

Changed in nova:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/492395
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=2e5f293f13e8f38e8cb6b4b58bd69d04eb808b9e
Submitter: Jenkins
Branch: master

commit 2e5f293f13e8f38e8cb6b4b58bd69d04eb808b9e
Author: He Jie Xu <email address hidden>
Date: Thu Aug 10 14:49:29 2017 +0800

    placement: avoid returning duplicated alloc_reqs when no sharing rp

    This patch returns from the loop early where there are no sharing
    rps, avoiding generating duplicated requests.

    Change-Id: I7c73b720f09bb2371770b1c6de537bb5527785a9
    Closes-Bug: #1709788

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/508885

Matt Riedemann (mriedem)
Changed in nova:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 17.0.0.0b1

This issue was fixed in the openstack/nova 17.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/pike)

Reviewed: https://review.openstack.org/508885
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=8f765408ffcccd8802b4ffb33806e7db15a1029f
Submitter: Zuul
Branch: stable/pike

commit 8f765408ffcccd8802b4ffb33806e7db15a1029f
Author: He Jie Xu <email address hidden>
Date: Thu Aug 10 14:49:29 2017 +0800

    placement: avoid returning duplicated alloc_reqs when no sharing rp

    This patch returns from the loop early where there are no sharing
    rps, avoiding generating duplicated requests.

    Change-Id: I7c73b720f09bb2371770b1c6de537bb5527785a9
    Closes-Bug: #1709788
    (cherry picked from commit 2e5f293f13e8f38e8cb6b4b58bd69d04eb808b9e)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 16.0.4

This issue was fixed in the openstack/nova 16.0.4 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.