OpenStack Compute (nova)

Live migration failed: Unable to parse URI qemu+ssh://nova_migration@fd00:

Series ocata
Bug #1786058

Bug #1786058 reported by Sergii Golovatiuk on 2018-08-08

This bug affects 1 person

	Status	Importance	Assigned to
OpenStack Compute (nova)	Fix Released	Medium	Sergii Golovatiuk
Ocata	In Progress	Medium	Lee Yarwood
Pike	In Progress	Medium	Lee Yarwood
Queens	Fix Committed	Medium	Lee Yarwood
Rocky	Fix Committed	Medium	Sahid Orentino

Bug Description

Unable to parse URI qemu+ssh://nova_migration@fd00:fd00:fd00:2000::1e/system?keyfile=/etc/nova/migration/identity

IPv6 URI should be wrapped in [], to avoid ambiguity wrt port number.

nova/virt/libvirt/driver.py needs some logic to wrap IPv6 addresses to brackets. Otherwise live migration will fail due to malformed URI

Tags:

Sergii Golovatiuk (sgolovatiuk) on 2018-08-08

Changed in nova:
assignee:	nobody → Sergii Golovatiuk (sgolovatiuk)

OpenStack Infra (hudson-openstack) on 2018-08-08

Changed in nova:
status:	New → In Progress

OpenStack Infra (hudson-openstack) on 2018-08-22

Changed in nova:
assignee:	Sergii Golovatiuk (sgolovatiuk) → Matt Riedemann (mriedem)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-08-22: Fix merged to nova (master)

Reviewed: https://review.openstack.org/589548
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=8b019d6f1e7893a7e308bd79c879e94d3400e007
Submitter: Zuul
Branch: master

commit 8b019d6f1e7893a7e308bd79c879e94d3400e007
Author: Sergii Golovatiuk <email address hidden>
Date: Tue Aug 7 19:49:37 2018 +0300

libvirt: Always escape IPv6 addresses when used in migration URI

    If IPv6 is passed to URI it should be wrapped within square brackets.
    This patch detects IPv6 to form migration URI properly. Domain name, IPv4 or
    already bracketed IPv6 address will pass as is

Extend tests to include collapsed IPv6 addresses and IPv6 addresses with
port

Change-Id: I1201db996ea6ceaebd49479b298d74585a78b006
Closes-Bug: #1786058

Changed in nova:
status:	In Progress → Fix Released

Matt Riedemann (mriedem) on 2018-08-22

Changed in nova:
importance:	Undecided → Medium
tags:	added: ipv6 libvirt live-migration
Changed in nova:
assignee:	Matt Riedemann (mriedem) → Sergii Golovatiuk (sgolovatiuk)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-09-03: Fix proposed to nova (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/599419

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-09-12: Fix merged to nova (stable/rocky)

Reviewed: https://review.openstack.org/599419
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=7ee5499e5507c45249945fa5baf7665bc2f1cc02
Submitter: Zuul
Branch: stable/rocky

commit 7ee5499e5507c45249945fa5baf7665bc2f1cc02
Author: Sergii Golovatiuk <email address hidden>
Date: Tue Aug 7 19:49:37 2018 +0300

libvirt: Always escape IPv6 addresses when used in migration URI

Extend tests to include collapsed IPv6 addresses and IPv6 addresses with
port

    Change-Id: I1201db996ea6ceaebd49479b298d74585a78b006
    Closes-Bug: #1786058
    (cherry picked from commit 8b019d6f1e7893a7e308bd79c879e94d3400e007)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-09-19: Fix proposed to nova (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/603737

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-09-19: Fix proposed to nova (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/603738

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-09-19: Fix proposed to nova (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/603740

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-09-24: Fix included in openstack/nova 18.0.1

This issue was fixed in the openstack/nova 18.0.1 release.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-09-28: Fix merged to nova (stable/queens)

Reviewed: https://review.openstack.org/603737
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=551a7a459c6503158cb4512fec8b2dc9c0641abe
Submitter: Zuul
Branch: stable/queens

commit 551a7a459c6503158cb4512fec8b2dc9c0641abe
Author: Sergii Golovatiuk <email address hidden>
Date: Tue Aug 7 19:49:37 2018 +0300

libvirt: Always escape IPv6 addresses when used in migration URI

Extend tests to include collapsed IPv6 addresses and IPv6 addresses with
port

    Change-Id: I1201db996ea6ceaebd49479b298d74585a78b006
    Closes-Bug: #1786058
    (cherry picked from commit 8b019d6f1e7893a7e308bd79c879e94d3400e007)
    (cherry picked from commit 7ee5499e5507c45249945fa5baf7665bc2f1cc02)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-10-05: Change abandoned on nova (stable/pike)

Change abandoned by Lee Yarwood (<email address hidden>) on branch: stable/pike
Review: https://review.openstack.org/603738
Reason: Apologies, finally getting around to looking at this now and as Icdcf681c1d71a09b88b029f80d13cd5015dacd56 landed in stable/queens we can't use it prior to this in Nova. Closing this out.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-10-05: Change abandoned on nova (stable/ocata)

#10

Change abandoned by Lee Yarwood (<email address hidden>) on branch: stable/ocata
Review: https://review.openstack.org/603740
Reason: Apologies, finally getting around to looking at this now and as Icdcf681c1d71a09b88b029f80d13cd5015dacd56 landed in stable/queens we can't use it prior to this in Nova. Closing this out.