Unshelve instance can't find the image error message is not updated to the instance fault table

[Brin Zhang]

When deleting the image of an instance of the SHELVED_OFFLOADED state and then executing the unshelve instance operation, the unshelve instance fails, but there is no corresponding error message in the fault table of the target instance.

You can reproduce the bug by following the steps below：
1.Create an instance in your environment, named "instance01", then do "Shelve Instance";
2.The first step, if executed successfully, will generate an image named "instance01-shelved", select and delete it;
3.Return to the instance list, find the target instance, and then do "Unshelve instance". The status of this instance will be set to Error, but there is no error message in the instance fault table.

I think that I have seen an error in the instance, but I don’t know why it is wrong. This is unfriendly.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/579747
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=b26df4fa6cd78a9b60de79750d4e9a58980d13ca
Submitter: Zuul
Branch: master

commit b26df4fa6cd78a9b60de79750d4e9a58980d13ca
Author: zhangbailin <email address hidden>
Date: Tue Jul 3 11:08:04 2018 +0800

    Add unshelve instance error info to fault table

    When the image of the SHELVED_OFFLOADED instance is deleted, the unshelve
    instance will report an error, but the fault info not added into instance
    fault table.

    Closes-bug: #1779826

    Change-Id: I365fcc148b27959acad1d3c4f8bb45c1ed790318

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/583418

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/583422

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/583426

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/583418
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=d543ddda02311986d5318a14dd21a3393df37c3e
Submitter: Zuul
Branch: stable/queens

commit d543ddda02311986d5318a14dd21a3393df37c3e
Author: zhangbailin <email address hidden>
Date: Tue Jul 3 11:08:04 2018 +0800

    Add unshelve instance error info to fault table

    When the image of the SHELVED_OFFLOADED instance is deleted, the unshelve
    instance will report an error, but the fault info not added into instance
    fault table.

    Closes-bug: #1779826

    Change-Id: I365fcc148b27959acad1d3c4f8bb45c1ed790318
    (cherry picked from commit b26df4fa6cd78a9b60de79750d4e9a58980d13ca)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 18.0.0.0b3 development milestone.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/583426
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=1316e08c85456ca69bc55bf9a90a24e341884952
Submitter: Zuul
Branch: stable/pike

commit 1316e08c85456ca69bc55bf9a90a24e341884952
Author: zhangbailin <email address hidden>
Date: Tue Jul 3 11:08:04 2018 +0800

    Add unshelve instance error info to fault table

    When the image of the SHELVED_OFFLOADED instance is deleted, the unshelve
    instance will report an error, but the fault info not added into instance
    fault table.

    Closes-bug: #1779826

    Change-Id: I365fcc148b27959acad1d3c4f8bb45c1ed790318
    (cherry picked from commit b26df4fa6cd78a9b60de79750d4e9a58980d13ca)
    (cherry picked from commit d543ddda02311986d5318a14dd21a3393df37c3e)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 16.1.5 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 17.0.6 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/583422
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=0217a2cac969eb5dd82d95e051df1cac3c0ab70d
Submitter: Zuul
Branch: stable/ocata

commit 0217a2cac969eb5dd82d95e051df1cac3c0ab70d
Author: zhangbailin <email address hidden>
Date: Tue Jul 3 11:08:04 2018 +0800

    Add unshelve instance error info to fault table

    When the image of the SHELVED_OFFLOADED instance is deleted, the unshelve
    instance will report an error, but the fault info not added into instance
    fault table.

    Closes-bug: #1779826

    Change-Id: I365fcc148b27959acad1d3c4f8bb45c1ed790318
    (cherry picked from commit b26df4fa6cd78a9b60de79750d4e9a58980d13ca)
    (cherry picked from commit d543ddda02311986d5318a14dd21a3393df37c3e)
    (cherry picked from commit 1316e08c85456ca69bc55bf9a90a24e341884952)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 15.1.5 release.