nova functional test does not triggered on notification sample only changes

Bug #1742962 reported by Balazs Gibizer
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
High
Balazs Gibizer
Ocata
Fix Committed
Medium
Matt Riedemann
Pike
Fix Committed
Medium
Matt Riedemann

Bug Description

As it is discovered during https://bugs.launchpad.net/nova/+bug/1742935 the openstack-tox-functional job does not trigger on commits only changing the notification sample files. But those files are used during the functional test so it can break it.

Tags: testing
Changed in nova:
assignee: nobody → Balazs Gibizer (balazs-gibizer)
tags: added: testing
Changed in nova:
status: New → In Progress
Changed in nova:
assignee: Balazs Gibizer (balazs-gibizer) → Andreas Jaeger (jaegerandi)
Changed in nova:
assignee: Andreas Jaeger (jaegerandi) → Balazs Gibizer (balazs-gibizer)
Changed in nova:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/536934

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/536936

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/533210
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=d4377c2d537ea998ed96cc8d7071877eefab994f
Submitter: Zuul
Branch: master

commit d4377c2d537ea998ed96cc8d7071877eefab994f
Author: Balazs Gibizer <email address hidden>
Date: Fri Jan 12 16:23:00 2018 +0100

    Make sure that functional test triggered on sample changes

    To be able to define different irrelevant-files for the functional jobs
    than the ones defined in openstack-zuul-jobs we need to copy the jobs to
    the nova tree and modify the fields in tree.

    Technically we could factor out the irrelevant-files regexp list from
    functional and functional-py35 jobs as they are the same today. However
    in the future when they diverge we cannot simply override the
    irrelevant-files in one of the jobs. Therefore this patch does not
    introduce a common base job for functinal and functional-py35 jobs
    to discurage trying to override.

    The openstack-tox-functional and fuctional-py35 are removed from the
    nova part of the project-config in
    I56d44f8dff41dbf3b2ff2382fa39b364f55f9a44

    Closes-Bug: #1742962
    Change-Id: Ia684786d1622da7af31aa4479fc883a7c65848ff

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/pike)

Reviewed: https://review.openstack.org/536934
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=274e2e61187030332d5d427d2272b48a26a0012a
Submitter: Zuul
Branch: stable/pike

commit 274e2e61187030332d5d427d2272b48a26a0012a
Author: Balazs Gibizer <email address hidden>
Date: Fri Jan 12 16:23:00 2018 +0100

    Make sure that functional test triggered on sample changes

    To be able to define different irrelevant-files for the functional jobs
    than the ones defined in openstack-zuul-jobs we need to copy the jobs to
    the nova tree and modify the fields in tree.

    Technically we could factor out the irrelevant-files regexp list from
    functional and functional-py35 jobs as they are the same today. However
    in the future when they diverge we cannot simply override the
    irrelevant-files in one of the jobs. Therefore this patch does not
    introduce a common base job for functinal and functional-py35 jobs
    to discurage trying to override.

    The openstack-tox-functional and fuctional-py35 are removed from the
    nova part of the project-config in
    I56d44f8dff41dbf3b2ff2382fa39b364f55f9a44

    Conflicts:
          .zuul.yaml

    NOTE(mriedem): The conflict is due ot the nova-lvm job definition
    not existing in Pike, which is OK because it's a non-voting job
    that runs in the experimental queue so we don't need it in Pike.

    Depends-On: https://review.openstack.org/538619/

    Closes-Bug: #1742962
    Change-Id: Ia684786d1622da7af31aa4479fc883a7c65848ff
    (cherry picked from commit d4377c2d537ea998ed96cc8d7071877eefab994f)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/ocata)

Reviewed: https://review.openstack.org/536936
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=0b5006d45af0df1720053c8f7870369022447a2f
Submitter: Zuul
Branch: stable/ocata

commit 0b5006d45af0df1720053c8f7870369022447a2f
Author: Balazs Gibizer <email address hidden>
Date: Fri Jan 12 16:23:00 2018 +0100

    Make sure that functional test triggered on sample changes

    To be able to define different irrelevant-files for the functional jobs
    than the ones defined in openstack-zuul-jobs we need to copy the jobs to
    the nova tree and modify the fields in tree.

    Technically we could factor out the irrelevant-files regexp list from
    functional and functional-py35 jobs as they are the same today. However
    in the future when they diverge we cannot simply override the
    irrelevant-files in one of the jobs. Therefore this patch does not
    introduce a common base job for functinal and functional-py35 jobs
    to discurage trying to override.

    The openstack-tox-functional and fuctional-py35 are removed from the
    nova part of the project-config in
    I56d44f8dff41dbf3b2ff2382fa39b364f55f9a44

    NOTE(mriedem): The nova-tox-functional-py35 job is not backported to
    Ocata because the job didn't work until Pike.

    Depends-On: https://review.openstack.org/538619/

    Closes-Bug: #1742962
    Change-Id: Ia684786d1622da7af31aa4479fc883a7c65848ff
    (cherry picked from commit d4377c2d537ea998ed96cc8d7071877eefab994f)
    (cherry picked from commit efa832f35de06db6f673e89e6d2f164ac5c6c2c9)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 17.0.0.0rc1

This issue was fixed in the openstack/nova 17.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 16.1.0

This issue was fixed in the openstack/nova 16.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 15.1.1

This issue was fixed in the openstack/nova 15.1.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.