debug message not correct in inject_data

[Henry]

When creating instance with files to inject,it would use _inject_data method in nova, then one incorrect debug message in nova-compute.log:

2017-11-01 17:38:15.083 26293 DEBUG nova.virt.libvirt.driver [req-278573ea-702c-4c4a-8b9d-ff25dd2af764 admin admin] [instance: 20e9bd26-028e-4051-bd99-ef30cb39228d] Checking root disk injection %(info)s _inject_data /opt/stack/nova/nova/virt/libvirt/driver.py:3160

I guess that attemps to show all inject_info such as network_info,admin_pass,files.So it should be modified in _inject_data.

[Matt Riedemann (mriedem)]

This looks correct to me, I don't really understand your point in why you think this is a bug:

LOG.debug('Checking root disk injection %(info)s',
          info=str(injection_info), instance=instance)

[Henry (guanzy)]

In this code, it attempts to show injection_info, while debug log message is that:"Checking root disk injection %(info)s ",can not format injection_info. So I think it should be modified here.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/517227

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/517227
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=76a4e42e8bb98c8d5f30d8fef7b0fafd3976b626
Submitter: Zuul
Branch: master

commit 76a4e42e8bb98c8d5f30d8fef7b0fafd3976b626
Author: guanzuoyu <email address hidden>
Date: Thu Nov 2 16:49:22 2017 +0800

    Modify incorrect debug meaasge in _inject_data

    It attempts to show inject_info but can not format by %(info)
    correctly,so we can use string directly.

    Change-Id: Ib9c67757e0b1d833cf722eb8dfcc47a4414b6fb6
    Closes-Bug: #1729294

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/519950

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/519951

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/519951
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=4402da85cd5fe03809989373b4670adc7beb40f0
Submitter: Zuul
Branch: stable/pike

commit 4402da85cd5fe03809989373b4670adc7beb40f0
Author: guanzuoyu <email address hidden>
Date: Thu Nov 2 16:49:22 2017 +0800

    Modify incorrect debug meaasge in _inject_data

    It attempts to show inject_info but can not format by %(info)
    correctly,so we can use string directly.

    Change-Id: Ib9c67757e0b1d833cf722eb8dfcc47a4414b6fb6
    Closes-Bug: #1729294
    (cherry picked from commit 76a4e42e8bb98c8d5f30d8fef7b0fafd3976b626)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 17.0.0.0b2 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 16.0.4 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/519950
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=db797970c3dcdf639dbbba2326b879dbcec1a227
Submitter: Zuul
Branch: stable/ocata

commit db797970c3dcdf639dbbba2326b879dbcec1a227
Author: guanzuoyu <email address hidden>
Date: Thu Nov 2 16:49:22 2017 +0800

    Modify incorrect debug meaasge in _inject_data

    It attempts to show inject_info but can not format by %(info)
    correctly,so we can use string directly.

    Change-Id: Ib9c67757e0b1d833cf722eb8dfcc47a4414b6fb6
    Closes-Bug: #1729294
    (cherry picked from commit 76a4e42e8bb98c8d5f30d8fef7b0fafd3976b626)
    (cherry picked from commit 4402da85cd5fe03809989373b4670adc7beb40f0)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 15.1.1 release.