compute.metrics.update is not a versioned notification and not whitelisted. See ./doc/source/notification.rst

[Matthew Thode]

From gibi:

The metrics.update should have been whitelisted but we didn't found that as there is no test coverage for that notification

I found it out when updating my config for pike.

[Matt Riedemann (mriedem)]

I'm not sure what "whitelisted" means here - does that mean it should simply be listed here?

https://github.com/openstack/nova/blob/0aeaa2bce8ad15bc2f28e00b30d688514b992e13/nova/rpc.py#L250

[Matt Riedemann (mriedem)]

This goes back to https://github.com/openstack/nova/commit/590d40c in mitaka.

[Matt Riedemann (mriedem)]

To recreate, configure nova.conf to set:

[DEFAULT]
compute_monitors = nova.compute.monitors.cpu.virt_driver

[Matthew Thode (prometheanfire)]

Another warning is emitted if the following is missing from the [DEFAULT] section of nova.conf.

compute_monitors = nova.compute.monitors.cpu.virt_driver

when I add that to the config I get the follow up warning (
compute.metrics.update is not a versioned notification and not whitelisted. See ./doc/source/notification.rst)

[Matt Riedemann (mriedem)]

Since gerrit is currently down I've attached a patch.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/504978

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/504978
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=963bf956ce93ba02bf9f38f979fe914d090b76d4
Submitter: Jenkins
Branch: master

commit 963bf956ce93ba02bf9f38f979fe914d090b76d4
Author: Matt Riedemann <email address hidden>
Date: Mon Sep 18 15:30:18 2017 -0400

    Account for compute.metrics.update in legacy notification whitelist

    The compute.metrics.update legacy unversioned notification was missing
    from the whitelist because the only test for it was mocking out the
    rpc notifier call, which is what validates the entries in the whitelist.

    This adds the entry to the whitelist and fixes the test to actually
    use the notifier code.

    Change-Id: Ie278ca58c371b8e3bd4861e6c86ebcf30c6778ea
    Closes-Bug: #1717943

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/509439

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/509440

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/509441

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/509441
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=1d2cfc4f5689fa1d88fb9aa13be14a6b7cc17a89
Submitter: Zuul
Branch: stable/newton

commit 1d2cfc4f5689fa1d88fb9aa13be14a6b7cc17a89
Author: Matt Riedemann <email address hidden>
Date: Mon Sep 18 15:30:18 2017 -0400

    Account for compute.metrics.update in legacy notification whitelist

    The compute.metrics.update legacy unversioned notification was missing
    from the whitelist because the only test for it was mocking out the
    rpc notifier call, which is what validates the entries in the whitelist.

    This adds the entry to the whitelist and fixes the test to actually
    use the notifier code.

    Change-Id: Ie278ca58c371b8e3bd4861e6c86ebcf30c6778ea
    Closes-Bug: #1717943
    (cherry picked from commit 963bf956ce93ba02bf9f38f979fe914d090b76d4)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/509440
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=1c88f3f75d827610be925f68b076253dba76cfcc
Submitter: Zuul
Branch: stable/ocata

commit 1c88f3f75d827610be925f68b076253dba76cfcc
Author: Matt Riedemann <email address hidden>
Date: Mon Sep 18 15:30:18 2017 -0400

    Account for compute.metrics.update in legacy notification whitelist

    The compute.metrics.update legacy unversioned notification was missing
    from the whitelist because the only test for it was mocking out the
    rpc notifier call, which is what validates the entries in the whitelist.

    This adds the entry to the whitelist and fixes the test to actually
    use the notifier code.

    Change-Id: Ie278ca58c371b8e3bd4861e6c86ebcf30c6778ea
    Closes-Bug: #1717943
    (cherry picked from commit 963bf956ce93ba02bf9f38f979fe914d090b76d4)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/509439
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=1a1b65fac9ed429516338bc468144bf742c94824
Submitter: Zuul
Branch: stable/pike

commit 1a1b65fac9ed429516338bc468144bf742c94824
Author: Matt Riedemann <email address hidden>
Date: Mon Sep 18 15:30:18 2017 -0400

    Account for compute.metrics.update in legacy notification whitelist

    The compute.metrics.update legacy unversioned notification was missing
    from the whitelist because the only test for it was mocking out the
    rpc notifier call, which is what validates the entries in the whitelist.

    This adds the entry to the whitelist and fixes the test to actually
    use the notifier code.

    Change-Id: Ie278ca58c371b8e3bd4861e6c86ebcf30c6778ea
    Closes-Bug: #1717943
    (cherry picked from commit 963bf956ce93ba02bf9f38f979fe914d090b76d4)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 17.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 14.0.9 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 15.0.8 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 16.0.3 release.