should capture quota exceed error from cinder when create image for volume backed instance

[Zhenyu Zheng]

When create image for a volume backed instance, nova will create snapshots for all
volumes attached to the instance in Cinder, and if quota exceed in Cinder, HTTP
500 will raise, we should capture this error and raise 404.

[Matt Riedemann (mriedem)]

Kevin, can you please provide recreate steps or links to specific code?

[Matt Riedemann (mriedem)]

Oh I see, here:

https://github.com/openstack/nova/blob/5532d6f4042aa41d1bd9e2e4a7fabb63a0ab6b93/nova/compute/api.py#L2987

That would raise this exception:

https://github.com/openstack/nova/blob/5532d6f4042aa41d1bd9e2e4a7fabb63a0ab6b93/nova/volume/cinder.py#L242

And yeah we don't handle that in the exceptions here:

https://github.com/openstack/nova/blob/5532d6f4042aa41d1bd9e2e4a7fabb63a0ab6b93/nova/api/openstack/compute/servers.py#L996

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/464548
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=29c8ae3cd9653b310c3fac803e6295e5fa885d15
Submitter: Jenkins
Branch: master

commit 29c8ae3cd9653b310c3fac803e6295e5fa885d15
Author: Kevin_Zheng <email address hidden>
Date: Mon May 15 15:02:00 2017 +0800

    Catch exception.OverQuota when create image for volume backed instance

    When create image for a volume backed instance, nova will
    create snapshots for all volumes attached to the instance
    in Cinder, and if quota exceed in Cinder, HTTP 500 will
    raise, we should capture this error and raise 403.

    Change-Id: Ic62478e22a7477cfaefac3e63c383082d66bd635
    Closes-Bug: #1689284

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/467028

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/467028
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=1b59d60f9520c7a1992a5753517e472f6dd8b85d
Submitter: Jenkins
Branch: stable/ocata

commit 1b59d60f9520c7a1992a5753517e472f6dd8b85d
Author: Kevin_Zheng <email address hidden>
Date: Mon May 15 15:02:00 2017 +0800

    Catch exception.OverQuota when create image for volume backed instance

    When create image for a volume backed instance, nova will
    create snapshots for all volumes attached to the instance
    in Cinder, and if quota exceed in Cinder, HTTP 500 will
    raise, we should capture this error and raise 403.

    Change-Id: Ic62478e22a7477cfaefac3e63c383082d66bd635
    Closes-Bug: #1689284
    (cherry picked from commit 29c8ae3cd9653b310c3fac803e6295e5fa885d15)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/467441

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 15.0.5 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 16.0.0.0b2 development milestone.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/467441
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=5448a44c703c96d38ebfaf768214bf0600364c5b
Submitter: Jenkins
Branch: stable/newton

commit 5448a44c703c96d38ebfaf768214bf0600364c5b
Author: Kevin_Zheng <email address hidden>
Date: Mon May 15 15:02:00 2017 +0800

    Catch exception.OverQuota when create image for volume backed instance

    When create image for a volume backed instance, nova will
    create snapshots for all volumes attached to the instance
    in Cinder, and if quota exceed in Cinder, HTTP 500 will
    raise, we should capture this error and raise 403.

    Conflicts:
          nova/tests/unit/api/openstack/compute/test_server_actions.py

    NOTE(mriedem): The conflict is due to the tests being refactored
    to not use mox in Ocata: 612134ca7bd972e5cbd0d149ab1b45b2ec51ad49

    Change-Id: Ic62478e22a7477cfaefac3e63c383082d66bd635
    Closes-Bug: #1689284
    (cherry picked from commit 29c8ae3cd9653b310c3fac803e6295e5fa885d15)
    (cherry picked from commit 1b59d60f9520c7a1992a5753517e472f6dd8b85d)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 14.0.8 release.