Evacuated instances that are deleted before the source host comes up causes cleanup not to happen

[Matt Rabe]

Description
===========
When an instance is evacuated to another host, the VM remains on the source host until it is brought back up and deleted by compute via _destroy_evacuated_instances.

However if the VM that's created on the destination is deleted before the source host is brought back up, then _destroy_evacuated_instances won't reap the remains because it searches non-deleted records.

Steps to reproduce
==================
1. Deploy a VM.
2. Bring the host the VM is on down.
3. Evacuate the VM to a different host.
4. Delete the VM from the destination.
5. Bring the source host back up.

The source remnants from the evacuation will not be cleaned up, but they should be.

Suspect code is in the nova compute manager in _destroy_evacuated_instances:

1. MigrationList.get_by_filters doesn't appear to return deleted migration records.
2. {'deleted': False} is currently passed as the filter to _get_instances_on_driver.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/467774

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/482620

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/467774
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=42b1fa965028c12d6e78b70d2487d5dd49158176
Submitter: Jenkins
Branch: master

commit 42b1fa965028c12d6e78b70d2487d5dd49158176
Author: mdrabe <email address hidden>
Date: Wed May 24 15:56:13 2017 -0500

    Query deleted instance records during _destroy_evacuated_instances

    _destroy_evacuated_instances is responsible for cleaning up the
    remnants of instance evacuations from the source host. Currently
    this method doesn't account for instances that have been deleted
    after being evacuated.

    Change-Id: Ib5f6b03189b7fc5cd0b226ea2dca74865fbef12a
    Closes-Bug: #1687479

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/482620
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=2954f0dfc913c3ad6ffe8c5f1178c6711f64eb9d
Submitter: Jenkins
Branch: stable/ocata

commit 2954f0dfc913c3ad6ffe8c5f1178c6711f64eb9d
Author: mdrabe <email address hidden>
Date: Wed May 24 15:56:13 2017 -0500

    Query deleted instance records during _destroy_evacuated_instances

    _destroy_evacuated_instances is responsible for cleaning up the
    remnants of instance evacuations from the source host. Currently
    this method doesn't account for instances that have been deleted
    after being evacuated.

    Change-Id: Ib5f6b03189b7fc5cd0b226ea2dca74865fbef12a
    Closes-Bug: #1687479
    (cherry picked from commit 42b1fa965028c12d6e78b70d2487d5dd49158176)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 16.0.0.0b3 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 15.0.7 release.