Comment 5 for bug 1670522

Reviewed: https://review.openstack.org/442550
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=30e604f57faa8321679881bdf6113f9389e80271
Submitter: Jenkins
Branch: stable/ocata

commit 30e604f57faa8321679881bdf6113f9389e80271
Author: Matt Riedemann <email address hidden>
Date: Mon Mar 6 19:00:31 2017 -0500

    libvirt: pass log_path to _create_pty_device for non-kvm/qemu

    log_path is required in _create_pty_device if:

    1. serial consoles are disabled
    2. libvirt/qemu are new enough that they support virtlogd

    This was working fine for kvm and qemu since _create_consoles_s390x
    and _create_consoles_qemu_kvm pass in the log_path, but for the
    non-kvm/qemu cases, like xen, the log_path wasn't provided.

    This wasn't caught by the XenProject CI since it's using libvirt
    1.3.1 which does not have virtlogd support so this path was
    not exercised and apparently not unit tested either.

    A release note is provided since this is a pretty severe bug if
    you're running new enough libvirt/qemu and not using kvm/qemu as
    the virt type because CONF.serial_console.enabled is False by
    default so you're going to have failed server creates immediately
    upon upgrading to Ocata.

    Change-Id: I7f60db1d243a75b90e3c0e53201cb6000ee95778
    Closes-Bug: #1670522
    (cherry picked from commit ac61abb7c74f1a8e3e9134bc045455fd9fdac0fa)