Description
===========
It seems that the Move instance creation to conductor commit [1] changed when and how the instance.delete notification is emitted for an unscheduled instance. Unfortunately the legacy notification doesn't have test coverage and the versioned notification coverage are still on review [2] for this case.
Before [1] the instance.delete for an unscheduled instance is emitted from here [3]. But after [1] the execution of the same delete operation goes to a new direction [4] and never reaches [3].
Before [1] the new test coverage in [2] was passing but now after [1] is merged the test_create_server_error fails as the instance.delete notification is not emitted.
[1] https://review.openstack.org/#/c/319379
[2] https://review.openstack.org/#/c/410297
[3] https://review.openstack.org/#/c/410297/9/nova/compute/api.py@1860
[4] https://review.openstack.org/#/c/319379/84/nova/compute/api.py@1790
Steps to reproduce
==================
Run the nova functional test in patch [2] before and after commit [1]. The test_create_server_error will pass before and fail after commit [1] due to missing instance.delete notification.
Environment
===========
Nova functional test env with based on commit f9d7b383a7cb12b6cd3e6117daf69b08620bf40f
Logs & Configs
==============
http://logs.openstack.org/97/410297/9/check/gate-nova-tox-functional-ubuntu-xenial/5875492/console.html#_2017-02-15_16_21_06_668774
Fix proposed to branch: master
Review: https:/