libvirt overwrites externally set vlan tags in macvtap passthrough mode with VFs

Bug #1657035 reported by Vladik Romanovsky on 2017-01-17
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Medium
Vladik Romanovsky
Newton
Medium
Matt Riedemann
Ocata
Medium
Matt Riedemann

Bug Description

Starting from version 1.3.5, Libvirt allows to set a vlan tag for macvtap
passthrough mode on SR-IOV VFs. Libvirt also removes any vlan tags that
has been set externally, by the ip link command.
Due to this, it's not possible to set a vlan for VFs with macvtap.

Changed in nova:
assignee: nobody → Vladik Romanovsky (vladik-romanovsky)

Fix proposed to branch: master
Review: https://review.openstack.org/421186

Changed in nova:
status: New → In Progress

Reviewed: https://review.openstack.org/421186
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=bf3ba76a91e362c0b3b8094964adc06f6a4ec62e
Submitter: Jenkins
Branch: master

commit bf3ba76a91e362c0b3b8094964adc06f6a4ec62e
Author: Vladik Romanovsky <email address hidden>
Date: Tue Jan 17 04:56:47 2017 -0500

    libvirt: set vlan tag for macvtap on SR-IOV VFs

    Starting from version 1.3.5, Libvirt allows to set a vlan tag for macvtap
    passthrough mode on SR-IOV VFs. Libvirt also removes any vlan tags that
    has been set externally, by the ip link command.

    In order to support the older libvirt versions, this code will make
    the behaviour backward compatible by checking the libvirt version.
    This can be completely removed once the minimum libvirt version will increase.

    Change-Id: Ia14e78e0eda81b8d29d5aa6e07e68777665d0710
    Closes-Bug: #1657035

Changed in nova:
status: In Progress → Fix Released
Matt Riedemann (mriedem) on 2017-03-21
Changed in nova:
importance: Undecided → Medium

Reviewed: https://review.openstack.org/448241
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=ce513278f15d251bae96b339fca2ffb2a05b28f6
Submitter: Jenkins
Branch: stable/ocata

commit ce513278f15d251bae96b339fca2ffb2a05b28f6
Author: Vladik Romanovsky <email address hidden>
Date: Tue Jan 17 04:56:47 2017 -0500

    libvirt: set vlan tag for macvtap on SR-IOV VFs

    Starting from version 1.3.5, Libvirt allows to set a vlan tag for macvtap
    passthrough mode on SR-IOV VFs. Libvirt also removes any vlan tags that
    has been set externally, by the ip link command.

    In order to support the older libvirt versions, this code will make
    the behaviour backward compatible by checking the libvirt version.
    This can be completely removed once the minimum libvirt version will increase.

    Change-Id: Ia14e78e0eda81b8d29d5aa6e07e68777665d0710
    Closes-Bug: #1657035
    (cherry picked from commit bf3ba76a91e362c0b3b8094964adc06f6a4ec62e)

This issue was fixed in the openstack/nova 15.0.3 release.

This issue was fixed in the openstack/nova 16.0.0.0b1 development milestone.

Reviewed: https://review.openstack.org/448235
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=adec640bfa5d560ce86aedea6a678a21b64823aa
Submitter: Jenkins
Branch: stable/newton

commit adec640bfa5d560ce86aedea6a678a21b64823aa
Author: Vladik Romanovsky <email address hidden>
Date: Tue Jan 17 04:56:47 2017 -0500

    libvirt: set vlan tag for macvtap on SR-IOV VFs

    Starting from version 1.3.5, Libvirt allows to set a vlan tag for macvtap
    passthrough mode on SR-IOV VFs. Libvirt also removes any vlan tags that
    has been set externally, by the ip link command.

    In order to support the older libvirt versions, this code will make
    the behaviour backward compatible by checking the libvirt version.
    This can be completely removed once the minimum libvirt version will increase.

    NOTE(mriedem): There is a slight modification in the test in Newton
    because 6a6457b5a6563b6cb4bf7673b00773d8208f5900 is not in Newton.

    Change-Id: Ia14e78e0eda81b8d29d5aa6e07e68777665d0710
    Closes-Bug: #1657035
    (cherry picked from commit bf3ba76a91e362c0b3b8094964adc06f6a4ec62e)
    (cherry picked from commit ce513278f15d251bae96b339fca2ffb2a05b28f6)

This issue was fixed in the openstack/nova 14.0.6 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers