instance.live.migration.force.complete is not a versioned notification and not whitelisted

Bug #1718485 reported by Balazs Gibizer
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Balazs Gibizer
Newton
Fix Committed
Medium
Matt Riedemann
Ocata
Fix Committed
Medium
Matt Riedemann
Pike
Fix Committed
Medium
Matt Riedemann

Bug Description

The instance.live.migration.force.complete legacy notification does not have any test coverage and therefore it is missed the whitelisting of allowed legacy notification. We should add test coverage and whitelist this notification.

This is a problem since I034b4041414a797f65ede52db2963107f2ef7456 is merged in the Mitaka cycle

tags: added: notifications
Changed in nova:
assignee: nobody → Balazs Gibizer (balazs-gibizer)
Matt Riedemann (mriedem)
Changed in nova:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/506104

Changed in nova:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/506104
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=b4778065e9a53f62d8ceee5889e1f1bbb61191d6
Submitter: Jenkins
Branch: master

commit b4778065e9a53f62d8ceee5889e1f1bbb61191d6
Author: Balazs Gibizer <email address hidden>
Date: Thu Sep 21 11:06:05 2017 +0200

    Add live.migration.force.complete to the legacy notification whitelist

    The instance.live.migration.force.complete notificatons are missing from the
    legacy notification whitelist as every test emiting them are mocked out
    the rpc notifier call.

    This patch adds the extra test coverage and whitelists the notifications

    Change-Id: Idf20fb435a7d11ff93bcb137699a38f5e4562d4c
    Closes-Bug: #1718485

Changed in nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/508877

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/508878

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/508902

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/newton)

Reviewed: https://review.openstack.org/508902
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=b234b8e13a6dcd97b3dbea69dcbd09e86bf80e83
Submitter: Zuul
Branch: stable/newton

commit b234b8e13a6dcd97b3dbea69dcbd09e86bf80e83
Author: Balazs Gibizer <email address hidden>
Date: Thu Sep 21 11:06:05 2017 +0200

    Add live.migration.force.complete to the legacy notification whitelist

    The instance.live.migration.force.complete notificatons are missing from the
    legacy notification whitelist as every test emiting them are mocked out
    the rpc notifier call.

    This patch adds the extra test coverage and whitelists the notifications

    Conflicts:
          nova/tests/unit/compute/test_compute_mgr.py

    NOTE(mriedem): Conflicts are due to not having change
    03e2f0449adf021774578cb3b457e284e831a509 or change
    7bb82e2dfdea30e22cff7d57b7dfa1d19b0e513b in Newton, neither
    of which are needed here.

    Change-Id: Idf20fb435a7d11ff93bcb137699a38f5e4562d4c
    Closes-Bug: #1718485
    (cherry picked from commit b4778065e9a53f62d8ceee5889e1f1bbb61191d6)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/pike)

Reviewed: https://review.openstack.org/508877
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=c82fc7d43e8480f1fc99125cad52e9fc3db33ed3
Submitter: Zuul
Branch: stable/pike

commit c82fc7d43e8480f1fc99125cad52e9fc3db33ed3
Author: Balazs Gibizer <email address hidden>
Date: Thu Sep 21 11:06:05 2017 +0200

    Add live.migration.force.complete to the legacy notification whitelist

    The instance.live.migration.force.complete notificatons are missing from the
    legacy notification whitelist as every test emiting them are mocked out
    the rpc notifier call.

    This patch adds the extra test coverage and whitelists the notifications

    Change-Id: Idf20fb435a7d11ff93bcb137699a38f5e4562d4c
    Closes-Bug: #1718485
    (cherry picked from commit b4778065e9a53f62d8ceee5889e1f1bbb61191d6)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/ocata)

Reviewed: https://review.openstack.org/508878
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=98cef3a7529d7e8756d39302300c921ba52246c2
Submitter: Zuul
Branch: stable/ocata

commit 98cef3a7529d7e8756d39302300c921ba52246c2
Author: Balazs Gibizer <email address hidden>
Date: Thu Sep 21 11:06:05 2017 +0200

    Add live.migration.force.complete to the legacy notification whitelist

    The instance.live.migration.force.complete notificatons are missing from the
    legacy notification whitelist as every test emiting them are mocked out
    the rpc notifier call.

    This patch adds the extra test coverage and whitelists the notifications

    Change-Id: Idf20fb435a7d11ff93bcb137699a38f5e4562d4c
    Closes-Bug: #1718485
    (cherry picked from commit b4778065e9a53f62d8ceee5889e1f1bbb61191d6)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 17.0.0.0b1

This issue was fixed in the openstack/nova 17.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 14.0.9

This issue was fixed in the openstack/nova 14.0.9 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 15.0.8

This issue was fixed in the openstack/nova 15.0.8 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/nova 16.0.3

This issue was fixed in the openstack/nova 16.0.3 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.