Libvirt LVM storage backend doesn't initialise filesystems of ephemeral disks

[Matthew Booth]

N.B. This is from code inspection only.

When creating an LVM-backed instance with an ephemeral disk, the ephemeral disk will not be initialised with the requested filesystem. This is because Image.cache() wraps the _create_ephemeral callback in fetch_func_sync, which will not call _create_ephemeral if the target already exists. Because the Lvm backend must create the disk first, this is never called.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/408152

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/408152
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=de5bb0c3fe9e86166e81aa2465a8e7791f64ba39
Submitter: Jenkins
Branch: master

commit de5bb0c3fe9e86166e81aa2465a8e7791f64ba39
Author: Matthew Booth <email address hidden>
Date: Wed Dec 7 14:45:40 2016 +0000

    libvirt: Fix initialising of LVM ephemeral disks

    The LVM backend expects to write directly to the target disk rather
    than to the image cache when initialising an ephemeral disk. This is
    confounded by Image.cache(), which doesn't call the given callback
    (_create_ephemeral in this case), if the target already exists.

    Closes-Bug: #1648109
    Co-authored-by: Feodor Tersin <email address hidden>
    Change-Id: Ic9178d6c013670611e63d54a7669f35dc9770e91

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/409708

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 15.0.0.0b2 development milestone.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Lee Yarwood (<email address hidden>) on branch: stable/newton
Review: https://review.openstack.org/409708