add more exceptions into spawn fail list

Bug #1646819 reported by jichenjc
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Opinion
Wishlist
Unassigned
Newton
In Progress
Low
Lee Yarwood

Bug Description

we need consider to stop spawn when some exceptions occur, already had some thing like following (part)

1985 except (exception.FlavorDiskTooSmall,
1986 exception.FlavorMemoryTooSmall,
1987 exception.ImageNotActive,
1988 exception.ImageUnacceptable,
1989 exception.InvalidDiskInfo,
1990 exception.InvalidDiskFormat,
1991 exception.SignatureVerificationError) as e:

we can add more so not only we can avoid useless retry, but also we can add more helpful info into InstanceFault instead of 'NoValidHost' info into InstanceFault

jichenjc (jichenjc)
Changed in nova:
assignee: nobody → jichenjc (jichenjc)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to nova (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/406109

Matt Riedemann (mriedem)
tags: added: compute spawn
Changed in nova:
status: New → In Progress
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/406109
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=d679f9a75bf87fb46e9f04a1b39f11f92219dc84
Submitter: Jenkins
Branch: master

commit d679f9a75bf87fb46e9f04a1b39f11f92219dc84
Author: jichenjc <email address hidden>
Date: Sun Nov 27 22:46:38 2016 +0800

    Catch VolumeEncryptionNotSupported during spawn

    this exception should be caught and return instead let
    scheduler retry as it's cloud/region wide exception, not
    some compute not ready issue.

    Change-Id: Ie855d441c1a65ca150ac50502832abcba1b554c3
    Partial-Bug: 1646819

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/416709

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/newton)

Reviewed: https://review.openstack.org/416709
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=fd55daa62fba650166a8897c92341773086a9868
Submitter: Jenkins
Branch: stable/newton

commit fd55daa62fba650166a8897c92341773086a9868
Author: jichenjc <email address hidden>
Date: Sun Nov 27 22:46:38 2016 +0800

    Catch VolumeEncryptionNotSupported during spawn

    this exception should be caught and return instead let
    scheduler retry as it's cloud/region wide exception, not
    some compute not ready issue.

    NOTE(lyarwood): Conflict caused by the use of the configurable
    fatal_exception_format_errors in stable/newton that is now removed in
    Ocata by Ia27d404. As a result we need to provide valid kwargs in the
    tests to avoid raising a KeyError.

    Conflicts:
            nova/tests/unit/compute/test_compute_mgr.py

    Change-Id: Ie855d441c1a65ca150ac50502832abcba1b554c3
    Partial-Bug: 1646819
    (cherry picked from commit d679f9a75bf87fb46e9f04a1b39f11f92219dc84)

tags: added: in-stable-newton
Revision history for this message
Sean Dague (sdague) wrote :

There are no currently open reviews on this bug, changing the status back to the previous state and unassigning. If there are active reviews related to this bug, please include links in comments.

Changed in nova:
status: In Progress → New
assignee: jichenjc (jichenjc) → nobody
Revision history for this message
Sean Dague (sdague) wrote :

it's fine to keep doing this, but the bug hasn't been updated as to what's left.

Changed in nova:
status: New → Opinion
importance: Low → Wishlist
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.