get_function_by_ifname does not return true for physical function

[edan david]

Due to a missing slash ('/') in the 'get_function_by_ifname' method (pci/utils),
an incorrect path was passed to read the number of VFs and determine if the device is a PF or not.

[Praveen N (praveenn)]

Hi Edan,
Can you please share more details !! ??
Thanks

[edan david (edand)]

Hi Praveen,
I've committed a fix, it's under review.
Have a look:
https://review.openstack.org/#/c/372558/2

[Praveen N (praveenn)]

Yup :)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/372558
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=859de9c9971a3dd13f245d2245686fb3d19a832d
Submitter: Jenkins
Branch: master

commit 859de9c9971a3dd13f245d2245686fb3d19a832d
Author: Edan David <email address hidden>
Date: Mon Sep 19 10:48:55 2016 -0400

    Add missing slash to dir path

    When validating a PF in the method 'get_function_by_ifname'
    the number of VFs are read from a file,
    the path to that file was missing a slash ('/').

    Change-Id: I7bf4bb96f1f769bff247f5af2c81dd96b08e2f04
    Closes-Bug: #1625220

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/375872

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/375873

[Matt Riedemann (mriedem)]

Was this a regression in newton?

[Matt Riedemann (mriedem)]

No, this isn't a regression, it looks like it's been this way since it was introduced in mitaka:

https://github.com/openstack/nova/commit/2ba4644f91aa523c2a14e32a168b853cf0b8c4e1

So we won't hold newton-rc2 for this.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/375872
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=464d3b8322b147ba51eac238b6498914b0b69985
Submitter: Jenkins
Branch: stable/newton

commit 464d3b8322b147ba51eac238b6498914b0b69985
Author: Edan David <email address hidden>
Date: Mon Sep 19 10:48:55 2016 -0400

    Add missing slash to dir path

    When validating a PF in the method 'get_function_by_ifname'
    the number of VFs are read from a file,
    the path to that file was missing a slash ('/').

    Change-Id: I7bf4bb96f1f769bff247f5af2c81dd96b08e2f04
    Closes-Bug: #1625220
    (cherry picked from commit 859de9c9971a3dd13f245d2245686fb3d19a832d)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 14.0.1 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/375873
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=3cd8d23a3a16b55dca3f8e8c552ea936f684d100
Submitter: Jenkins
Branch: stable/mitaka

commit 3cd8d23a3a16b55dca3f8e8c552ea936f684d100
Author: Edan David <email address hidden>
Date: Mon Sep 19 10:48:55 2016 -0400

    Add missing slash to dir path

    When validating a PF in the method 'get_function_by_ifname'
    the number of VFs are read from a file,
    the path to that file was missing a slash ('/').

    Change-Id: I7bf4bb96f1f769bff247f5af2c81dd96b08e2f04
    Closes-Bug: #1625220
    (cherry picked from commit 859de9c9971a3dd13f245d2245686fb3d19a832d)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 15.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 13.1.3 release.