Server group policies are not honored during live migration

[Pawel Koniszewski]

Commit https://github.com/openstack/nova/commit/111a852e79f0d9e54228d8e2724dc4183f737397 introduced regression that causes affinity/anti-affinity policies to be omitted while live migrating an instance.

This is because we don't pass instance_group here:

https://github.com/openstack/nova/blob/111a852e79f0d9e54228d8e2724dc4183f737397/nova/conductor/tasks/live_migrate.py#L183

However, filters are expecting this information:

https://github.com/openstack/nova/blob/111a852e79f0d9e54228d8e2724dc4183f737397/nova/scheduler/filters/affinity_filter.py#L86

Basically we should pass instance group so that filters can read this information later.

[John Garbutt (johngarbutt)]

Seems like a nasty regression, adding to mitaka rc2

[Sylvain Bauza (sylvain-bauza)]

It's a regression added by https://review.openstack.org/#/c/277800/ so it's a RC potential bug.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/296596

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/296661

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/296596
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=00efcf3a4171d270fc3a7b9b4a9230332aea81e6
Submitter: Jenkins
Branch: master

commit 00efcf3a4171d270fc3a7b9b4a9230332aea81e6
Author: Pawel Koniszewski <email address hidden>
Date: Wed Mar 23 18:44:10 2016 +0100

    Try to repopulate instance_group if it is None

    There are cases that we need to create new RequestSpect object and we
    pass None for instance_group argument. It might cause server group
    policies to be omitted during filtering phase. Therefore if
    instance_group is None we should try to repopulate instance_group
    basing on data that is in filter_properties.

    Change-Id: Id7e669e0a6db1ff1052c42006f1a141bdb8cdf29
    Closes-Bug: #1561022

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/296661
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=ad3c069f69ca1ab2c1d9c6c18d762b7c26c5ad92
Submitter: Jenkins
Branch: stable/mitaka

commit ad3c069f69ca1ab2c1d9c6c18d762b7c26c5ad92
Author: Pawel Koniszewski <email address hidden>
Date: Wed Mar 23 18:44:10 2016 +0100

    Try to repopulate instance_group if it is None

    There are cases that we need to create new RequestSpect object and we
    pass None for instance_group argument. It might cause server group
    policies to be omitted during filtering phase. Therefore if
    instance_group is None we should try to repopulate instance_group
    basing on data that is in filter_properties.

    Change-Id: Id7e669e0a6db1ff1052c42006f1a141bdb8cdf29
    Closes-Bug: #1561022
    (cherry picked from commit 00efcf3a4171d270fc3a7b9b4a9230332aea81e6)

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/nova 13.0.0.0rc2 release candidate.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/302578

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/302578
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=a8ebbebd4ee0c3bb1452ea32f92e1588a6b35067
Submitter: Jenkins
Branch: master

commit 7105f888ee1f52d2a462fc0ece3130dc0d3d49f5
Author: OpenStack Proposal Bot <email address hidden>
Date: Thu Mar 31 06:28:06 2016 +0000

    Imported Translations from Zanata

    For more information about this automatic import see:
    https://wiki.openstack.org/wiki/Translations/Infrastructure

    Change-Id: Ibe5d4d38834fbcb99c0332d3375659a21d94154e

commit 5de98cb2de2eca3d061488c55f96e6f7c9bc56a8
Author: OpenStack Proposal Bot <email address hidden>
Date: Wed Mar 30 06:41:25 2016 +0000

    Imported Translations from Zanata

    For more information about this automatic import see:
    https://wiki.openstack.org/wiki/Translations/Infrastructure

    Change-Id: Ia46d661560b1141c1c1522c9477c510d28a0d0e7

commit a9d55427b6e8d2472088e3d40a8a5151ce408283
Author: Moshe Levi <email address hidden>
Date: Wed Mar 23 10:59:04 2016 +0200

    Fix detach SR-IOV when using LibvirtConfigGuestHostdevPCI

    This patch fixes an issue which was introduced by this
    change If3edc1965c01a077eb61984a442e0d778d870d75.
    Usually the vif config is of type LibvirtConfigGuestInterface,
    but some vif use LibvirtConfigGuestHostdevPCI config
    (e.g. the ib_hostdev). The difference is that
    LibvirtConfigGuestInterface keeps the pci address in source_dev
    while LibvirtConfigGuestHostdevPCI has domain, bus, slot and
    function, instead of relying on the vif config type we can take the
    pci address for the neutron port.

    Closes-Bug: #1560860

    Change-Id: I62a7ff16f1c9c5da923451520fbeeabb5cc0c5c6
    (cherry picked from commit f15d9a9693b19393fcde84cf4bc6f044d39ffdca)

commit 5b6ee702df7ad901f68bec2ed8d43b66aa6d98c1
Author: OpenStack Proposal Bot <email address hidden>
Date: Tue Mar 29 06:37:30 2016 +0000

    Imported Translations from Zanata

    For more information about this automatic import see:
    https://wiki.openstack.org/wiki/Translations/Infrastructure

    Change-Id: Iad0e42a18bd3a7dcf216b4df17b9893e13382efe

commit 29042e06f7e570bd13607b62b997a6ae21db80c5
Author: OpenStack Proposal Bot <email address hidden>
Date: Mon Mar 28 06:34:19 2016 +0000

    Imported Translations from Zanata

    For more information about this automatic import see:
    https://wiki.openstack.org/wiki/Translations/Infrastructure

    Change-Id: If159133a2e32c6ef53ba104751a3eb054a95b733

commit 3e9819dab8249ec9993b0b9874e80a78f2ed1754
Author: Matt Riedemann <email address hidden>
Date: Sun Mar 27 19:31:32 2016 -0400

    Update cells blacklist regex for test_server_basic_ops

    Tempest change 9bee3b92f1559cb604c8bd74dcca57805a85a97a
    renamed a test in our blacklist so update the filter to
    handle the old and new name.

    The Tempest team is hesitant to revert the change so we
    should handle it ourselves and eventually move to using
    test uuids for our blacklist, but there might need to
    be work in devstack-gate for that fi...

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/nova 14.0.0.0b1 development milestone.