Duplicate lines in /etc/nova/policy.json

[Jerome Pansanel]

The default /etc/nova/policy.json released with Liberty contains two times the declaration for:
"compute:delete": "",
"compute:soft_delete": "",
"compute:force_delete": "",

I don't known it can impact the policy, but it may be better to raise an error when a rule is declared more than one time.

[Matt Kassawara (ionosphere80)]

Did you install from packages? Can you validate this issue in the upstream file?

[Jerome Pansanel (pansanel)]

The file has been installed from official RDO packages. The issue can also be found in the upstream file:
https://raw.githubusercontent.com/openstack/nova/stable/liberty/etc/nova/policy.json

[Matt Kassawara (ionosphere80)]

Bug belongs to the nova project.

[Markus Zoeller (markus_z) (mzoeller)]

I added "oslo.policy" because of this part of the report description:

> I don't known it can impact the policy, but it may be better
> to raise an error when a rule is declared more than one time.

@oslo folks: Would be good to know if this is a valid request.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/312431

[Markus Zoeller (markus_z) (mzoeller)]

Commit [1] introduced the delete targets with empty rules and commit [2] changed them in Mitaka incompletely to admin_or_owner rules.

[1] https://github.com/openstack/nova/commit/9c917816048482e3a42aa06e2aa4933a1a6f7f8c
[2] https://github.com/openstack/nova/commit/09a55e2bf4f3d5df3b76454f4839e2ce96f9d42f

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/312431
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=0e1bb7e36a19cd76175afc355ddbf28a41e6580b
Submitter: Jenkins
Branch: stable/liberty

commit 0e1bb7e36a19cd76175afc355ddbf28a41e6580b
Author: Rajesh Tailor <email address hidden>
Date: Wed May 4 06:19:17 2016 -0400

    Fix duplicate lines in policy.json

    Removed duplicate lines from etc/nova/policy.json file.

    Commit [1] introduced the delete targets with empty rules
    and commit [2] changed them in Liberty incompletely to
    admin_or_owner rules.

    [1] https://github.com/openstack/nova/commit/9c917816048482e3a42aa06e2aa4933a1a6f7f8c
    [2] https://github.com/openstack/nova/commit/09a55e2bf4f3d5df3b76454f4839e2ce96f9d42f

    Change-Id: I9081ccf28ec72a2d791cddac0597efef67e56429
    Closes-Bug:1577370

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 12.0.5 release.

[Steve Martinelli (stevemar)]

Not an oslo.policy bug, and it looks like this was fixed in nova.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 12.0.5 release.