failed automatically creating new SCSI controllers

[Zhao Zhe]

There can be at most 15 virtual disk attached on an SCSi controller, so if the limitation is reached, a new controller should be automatically created.

But I met an error when trying to attach the 15th volume to an instance.

It is reported as
"VMwareDriverException: Invalid configuration for device '0'"

[Vipin Balachandran (vbala)]

Volume vmdk is attached to the instance in the Nova driver.

[Zhao Zhe (zzbj)]

in a conclusion, my questions are:
1.
Is it designed to create a new controller when all existing controllers all reach their limits?
2.
If the answer of question 1 is yes, is this function tested to work?
3.
If the answers of question 1 and 2 are both yes, is my situation can be regarded as a bug?

[Zhao Zhe (zzbj)]

Here is the controller spec used for creating a new controller.

controller_spec : (VirtualDeviceConfigSpec){
   dynamicType = None
   dynamicProperty[] = <empty>
   operation = "add"
   fileOperation =
      (VirtualDeviceConfigSpecFileOperation){
         value = None
      }
   device =
      (VirtualLsiLogicController){
         dynamicType = None
         dynamicProperty[] = <empty>
         key = -101
         deviceInfo =
            (Description){
               dynamicType = None
               dynamicProperty[] = <empty>
               label = None
               summary = None
            }
         backing =
            (VirtualDeviceBackingInfo){
               dynamicType = None
               dynamicProperty[] = <empty>
            }
         connectable =
            (VirtualDeviceConnectInfo){
               dynamicType = None
               dynamicProperty[] = <empty>
               startConnected = None
               allowGuestControl = None
               connected = None
               status = None
            }
         slotInfo =
            (VirtualDeviceBusSlotInfo){
               dynamicType = None
               dynamicProperty[] = <empty>
            }
         controllerKey = None
         unitNumber = None
         busNumber = 0
         device[] = <empty>
         hotAddRemove = None
         sharedBus = "noSharing"
         scsiCtlrUnitNumber = None
      }
   profile[] = <empty>
 } ;

[Zhao Zhe (zzbj)]

Here is the vmdk_attach_config_spec.deviceChange before appending the controller spec above.

   deviceChange[] =
      (VirtualDeviceConfigSpec){
         dynamicType = None
         dynamicProperty[] = <empty>
         operation = "add"
         fileOperation =
            (VirtualDeviceConfigSpecFileOperation){
               value = None
            }
         device =
            (VirtualDisk){
               dynamicType = None
               dynamicProperty[] = <empty>
               key = -100
               deviceInfo =
                  (Description){
                     dynamicType = None
                     dynamicProperty[] = <empty>
                     label = None
                     summary = None
                  }
               backing =
                  (VirtualDiskFlatVer2BackingInfo){
                     dynamicType = None
                     dynamicProperty[] = <empty>
                     fileName = "[Silver_VA10-Development-07_SVC-C11_003] volume-876b285b-3969-40e6-b353-4f7c08da7827/volume-876b285b-3969-40e6-b353-4f7c08da7827.vmdk"
                     datastore =
                        (ManagedObjectReference){
                           value = None
                           _type = ""
                        }
                     backingObjectId = None
                     diskMode = "persistent"
                     split = None
                     writeThrough = None
                     thinProvisioned = True
                     eagerlyScrub = None
                     uuid = None
                     contentId = None
                     changeId = None
                     parent =
                        (VirtualDiskFlatVer2BackingInfo){
                           dynamicType = None
                           dynamicProperty[] = <empty>
                           fileName = None
                           datastore =
                              (ManagedObjectReference){
                                 value = None
                                 _type = ""
                              }
                           backingObjectId = None
                           diskMode = None
                           split = None
                           writeThrough = None
                           thinProvisioned = None
                           eagerlyScrub = None
                           uuid = None
                           contentId = None
                           changeId = None
                           deltaDiskFormat = None
                           digestEnabled = None
                           deltaGrainSize = None
                        }
                     deltaDiskFormat = None
                     digestEnabled = None
                     deltaGrainSize = None
                  }
               connectable =
                  (VirtualDeviceConnectInfo){
                     dynamicType = None
                     dynamicProperty[] = <empty>
                     startConnected = True
                     allowGuestControl = False
                     connected = True
                     status = None
                  }
               slotInfo =
                  (...

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/272414

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/272414
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=b36da5dd037219ceb71c4c6ea6925d2eba6cd59b
Submitter: Jenkins
Branch: master

commit b36da5dd037219ceb71c4c6ea6925d2eba6cd59b
Author: Feng Xi Yan <email address hidden>
Date: Tue Jan 26 15:13:36 2016 +0800

    <VMWare> Allocate free bus for new SCSI controller

    There are at most 16 virtual disks that can be attached onto a SCSI
    controller, while if the limitation is reached, error occurs
    with message "VMwareDriverException: Invalid configuration for
    device '0'".

    The reason is that when the controller's quota is used up, a new
    controller will be created automatically, but the newly-created
    one will try to use bus number 0, which is already used my existing
    controller.

    This change will allocate a new free bus number for the newly-created
    controller.

    Co-Authored-By: Qiaowei Ren <email address hidden>

    Closes bug: #1522232

    Change-Id: I2ced1358e682cda979d1d5bddb6359253699280b

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/299089

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/303995

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/303995
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=be033eef7296d132c8f7eb5e42203f5a3a947de6
Submitter: Jenkins
Branch: stable/mitaka

commit be033eef7296d132c8f7eb5e42203f5a3a947de6
Author: Feng Xi Yan <email address hidden>
Date: Tue Jan 26 15:13:36 2016 +0800

    <VMWare> Allocate free bus for new SCSI controller

    There are at most 16 virtual disks that can be attached onto a SCSI
    controller, while if the limitation is reached, error occurs
    with message "VMwareDriverException: Invalid configuration for
    device '0'".

    The reason is that when the controller's quota is used up, a new
    controller will be created automatically, but the newly-created
    one will try to use bus number 0, which is already used my existing
    controller.

    This change will allocate a new free bus number for the newly-created
    controller.

    Co-Authored-By: Qiaowei Ren <email address hidden>

    Closes bug: #1522232

    Change-Id: I2ced1358e682cda979d1d5bddb6359253699280b
    (cherry picked from commit b36da5dd037219ceb71c4c6ea6925d2eba6cd59b)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/299089
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=f593d90f7d0c02726fdfce24b29e163f1f55b707
Submitter: Jenkins
Branch: stable/liberty

commit f593d90f7d0c02726fdfce24b29e163f1f55b707
Author: Feng Xi Yan <email address hidden>
Date: Tue Jan 26 15:13:36 2016 +0800

    <VMWare> Allocate free bus for new SCSI controller

    There are at most 16 virtual disks that can be attached onto a SCSI
    controller, while if the limitation is reached, error occurs
    with message "VMwareDriverException: Invalid configuration for
    device '0'".

    The reason is that when the controller's quota is used up, a new
    controller will be created automatically, but the newly-created
    one will try to use bus number 0, which is already used my existing
    controller.

    This change will allocate a new free bus number for the newly-created
    controller.

    Co-Authored-By: Qiaowei Ren <email address hidden>

    Closes bug: #1522232

    Change-Id: I2ced1358e682cda979d1d5bddb6359253699280b
    (cherry picked from commit b36da5dd037219ceb71c4c6ea6925d2eba6cd59b)

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/nova 14.0.0.0b1 development milestone.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/nova 12.0.4 release.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/nova 13.1.0 release.