bulk-delete-floating-ip does not free used quota

[David Ripton]

The bulk-create-floating-ip and bulk-delete-floating-ip commands do not interact with floating_ip quotas. This is by design, since they're for admins rather than tenants.

However, in one case this causes a bug. If a tenant initially allocates the floating IP with create-floating-ip and consumed quota, and the admin later deletes the floating Ip with bulk-delete-floating-ip, the floating IP is freed but the quota is still consumed.

So we should change bulk-delete-floating-ip to release any quota that was associated with those floating IP addresses. (In many cases there will not be any so we need to check.)

This is https://bugzilla.redhat.com/show_bug.cgi?id=1029756 (but that bug is mostly private so won't people outside Red Hat much good).

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/65029

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/65029
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=384cce84fde784f9e2f39db49502c66e20ff0b4c
Submitter: Jenkins
Branch: master

commit 384cce84fde784f9e2f39db49502c66e20ff0b4c
Author: David Ripton <email address hidden>
Date: Sun Jan 5 23:15:14 2014 -0500

    Make floating_ip_bulk_destroy deallocate quota if not auto_assigned

    The expected use case for floating_ip_bulk_destroy is to destroy
    auto_assigned floating IPs, for which no quota is used so no quota
    needs to be recovered. But it can also be used to destroy other
    (not auto_assigned) floating IPs, in which case the previously used
    quota was not recovered. This fixes the quota leak in that unusual
    case.

    Closes-Bug: #1254174

    Change-Id: Ibff80d9ebac8d4422e401909033da12d9ec0b593

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/72549