OpenStack Compute (nova)

Unable to delete instance booted from an incorrect volume-id

Bug #1087214 reported by Unmesh Gurjar
28
This bug affects 3 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Unmesh Gurjar
OpenStack Compute (nova) 2013.1 "grizzly"

Bug Description

Branch: master

Steps to repro:
Spawn an instance specifying an incorrect/non-existing volume-id to boot from.

Expected Behavior:
Nova API should return a 400 Bad Request response with appropriate message 'Invalid volume provided'.

Actual Behavior:
Instance goes into an error state and the instance cannot be deleted (since cinderclient returns a 404 error during deletion).
The instance will persist forever in error state.

Tags: ntt
Unmesh Gurjar (unmesh-gurjar)
Changed in nova:
assignee: nobody → Unmesh Gurjar (unmesh-gurjar)
Revision history for this message
Unmesh Gurjar (unmesh-gurjar) wrote :

After observing the comments on a similar bug (https://bugs.launchpad.net/nova/+bug/1061576), I think instead of Nova API doing the validation, the delete instance should handle such scenarios robustly. Thereby enabling the user to delete such an instance successfully.

NOTE: The stack trace during deleting such instance is available here: http://paste.openstack.org/show/27817/.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/17847

Changed in nova:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/17847
Committed: http://github.com/openstack/nova/commit/921eec91abee56ea69e1b8b2bff59379b68bff87
Submitter: Jenkins
Branch: master

commit 921eec91abee56ea69e1b8b2bff59379b68bff87
Author: Unmesh Gurjar <email address hidden>
Date: Tue Dec 11 03:30:31 2012 -0800

    Fixed deleting instance booted from invalid vol

    1. Translated the exception (NotFound) raised from Cinder client to
    Nova's native exception (VolumeNotFound).
    2. Added unit test coverage.

    Fixes LP: #1087214.

    Change-Id: I3cee31a9fd068b65a4097f3f3054aebb69d9ba61

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → grizzly-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: grizzly-2 → 2013.1
Vish Ishaya (vishvananda)
Changed in nova:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/folsom)

Fix proposed to branch: stable/folsom
Review: https://review.openstack.org/38854

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/folsom)

Reviewed: https://review.openstack.org/38854
Committed: http://github.com/openstack/nova/commit/43e35a1ddc8fae157462771342352ebf937a07ba
Submitter: Jenkins
Branch: stable/folsom

commit 43e35a1ddc8fae157462771342352ebf937a07ba
Author: Unmesh Gurjar <email address hidden>
Date: Tue Dec 11 03:30:31 2012 -0800

    Fixed deleting instance booted from invalid vol

    1. Translated the exception (NotFound) raised from Cinder client to
    Nova's native exception (VolumeNotFound).
    2. Added unit test coverage.

    Fixes LP: #1087214.

    Change-Id: I3cee31a9fd068b65a4097f3f3054aebb69d9ba61
    (cherry picked from commit 921eec91abee56ea69e1b8b2bff59379b68bff87)

Sean Dague (sdague)
no longer affects: nova/folsom
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.