GetConsoleOutput in EC2 api requires InstanceId.1, when it should use InstanceId

[Ryan Lane]

The following traceback is received when using the aws-sdk for php:

2011-02-07 22:44:11,649 ERROR nova.api [RYYEHEIH632TIFF65E4G wikiadmin tesla] Unexpected error raised: invalid literal for int() with base 16: 'i'
(nova.api): TRACE: Traceback (most recent call last):
(nova.api): TRACE: File "/usr/lib/pymodules/python2.6/nova/api/ec2/__init__.py", line 317, in __call__
(nova.api): TRACE: result = api_request.invoke(context)
(nova.api): TRACE: File "/usr/lib/pymodules/python2.6/nova/api/ec2/apirequest.py", line 128, in invoke
(nova.api): TRACE: result = method(context, **args)
(nova.api): TRACE: File "/usr/lib/pymodules/python2.6/nova/api/ec2/cloud.py", line 517, in get_console_output
(nova.api): TRACE: instance_id = ec2_id_to_id(ec2_id)
(nova.api): TRACE: File "/usr/lib/pymodules/python2.6/nova/api/ec2/cloud.py", line 78, in ec2_id_to_id
(nova.api): TRACE: return int(ec2_id.split('-')[-1], 16)
(nova.api): TRACE: ValueError: invalid literal for int() with base 16: 'i'
(nova.api): TRACE:

Nova incorrectly required InstanceId.1, instead of InstanceId.

[Thierry Carrez (ttx)]

I'm looking into validating that this is indeed fixed in 2011.1.1 release candidates... but I'm not sure I understand how to reproduce the bug (or absence thereof). Ryan, any chance you can come up with a simple test case that I could use in validation ?

[Ryan Lane (rlane)]

I'm doing a new datacenter buildout for Wikimedia, so for the next week I have very little access to a computer. It'll be hard for me to write a test case right now.

Basically, GetConsoleOutput should return the console output when passing in a list, or just a string for this call in the EC2 API.

[Thierry Carrez (ttx)]

Verified on 2011.1.1 candidate with a patched boto, supports both cases.