strict constrain for the creation of db tables and columns

Bug #995124 reported by Vincent Hou
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Invalid
Wishlist
Unassigned

Bug Description

Some columns should be defined nullable=False,since they are unique in the table. For example, address in virtual_interfaces, host in aggregate_hosts, name in aggregates, etc. MySQL is ok, but databases with more strict column creation can yield errors, if it is not strictly defined.
Due to the same reason, method register_models in nova/db/sqlalchemy/models.py does not work for MYSQL. uuid in instance must be define unique and not null.

Tags: db
Vincent Hou (houshengbo)
Changed in nova:
status: New → In Progress
assignee: nobody → Vincent Hou (houshengbo)
status: In Progress → Fix Committed
Changed in nova:
status: Fix Committed → In Progress
Revision history for this message
Thierry Carrez (ttx) wrote :

Looks like you're not working on that anymore. Please set back to InProgress and reassign to you if you're working on proposing a change for merging.

Changed in nova:
assignee: Vincent Hou (houshengbo) → nobody
status: In Progress → Confirmed
Thierry Carrez (ttx)
Changed in nova:
status: Confirmed → New
Chuck Short (zulcss)
Changed in nova:
importance: Undecided → Wishlist
status: New → Confirmed
aeva black (tenbrae)
tags: added: db
Vincent Hou (houshengbo)
Changed in nova:
assignee: nobody → Vincent Hou (houshengbo)
Vincent Hou (houshengbo)
Changed in nova:
assignee: Vincent Hou (houshengbo) → nobody
Revision history for this message
Joe Gordon (jogo) wrote :

Is this still valid, this bug is fairly old and many things have changed since then.

Changed in nova:
status: Confirmed → Incomplete
Revision history for this message
Matt Riedemann (mriedem) wrote :

This is being worked by blueprint enforce-unique-instance-uuid-in-db:

https://blueprints.launchpad.net/nova/+spec/enforce-unique-instance-uuid-in-db

https://review.openstack.org/#/c/97946/

I'm going to track this bug against that blueprint and invalidate this.

Changed in nova:
status: Incomplete → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.