Could not find VM by name during delete in xenapi driver

[Johannes Erdfelt]

If an instance failed to build and is left in ERROR, then a subsequent delete in the xenapi driver will result in this error and instance fault:

Could not find VM by name

This is because the destroy method was changed to raise an exception if the instance couldn't be found on the xen server. It should be changed back to be more tolerant of that kind of failure.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/6658

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/6658
Committed: http://github.com/openstack/nova/commit/07d54c27a32e66884495b00ec7c19d679cdb823f
Submitter: Jenkins
Branch: master

commit 07d54c27a32e66884495b00ec7c19d679cdb823f
Author: Johannes Erdfelt <email address hidden>
Date: Thu Apr 19 15:06:27 2012 +0000

    Be more tolerant of deleting failed builds

    Fixes bug 985705

    If an instance fails to build, the xen server may not have an instance.
    This can cause _get_opaque_vm_ref to unnecessarily raise an exception
    and add an instance fault that is misleading.

    Change-Id: I068d0af284a5671f429b2d8b13a25b629ede59bd