Update servers with an invalid IPv4 is not raising bad request

[Rajalakshmi Ganesan]

Description:
    Updating servers with an invalid IPv4

Expected Result:
When IPv4 parameter of server is updated with invalid value, Bad Request Exception is supposed to be raised.

Actual Result:
Did not raise Bad Request

Log:
--------

Traceback (most recent call last):
File "/usr/local/lib/python2.7/dist-packages/unittest2-0.5.1-py2.7.egg/unittest2/case.py", line 340, in run
testMethod()
File "/usr/local/lib/python2.7/dist-packages/nose-1.1.2-py2.7.egg/nose/tools.py", line 87, in newfunc
raise AssertionError(message)
AssertionError: test_update_servers_011_with_invalid_IPv4() did not raise BadRequest
-------------------- >> begin captured logging << --------------------
novaclient.client: DEBUG: REQ: curl -i https://compute.systest.aw1.hpcloud.net/v1.1/54336735645370/servers/135530 PUT -H "X-Auth-Project-Id: <email address hidden>" -H "User-Agent: python-novaclient" -H "Content-Type: application/json" -H "X-Auth-Token: HPAuth_4f7e89fbe4b093d231119bcd"

novaclient.client: DEBUG: REQ BODY: {"server": {"accessIPv4": "invalidipv4a99"}}

novaclient.client: DEBUG: RESP:{'date': 'Fri, 06 Apr 2012 11:52:56 GMT', 'status': '200', 'content-length': '1073', 'content-type': 'application/json; charset=UTF-8'} {"server": {"status": "ACTIVE", "updated": "2012-04-06T11:52:56Z", "hostId": "6b27d387102f4a19ab0fb5bdb5a35c58bbaeb063bc809bcd52602f15", "user_id": "91856392262992", "name": "update_server_name&12", "links": [{"href": "https://compute.systest.aw1.hpcloud.net/v1.1/54336735645370/servers/135530", "rel": "self"}, {"href": "https://compute.systest.aw1.hpcloud.net/54336735645370/servers/135530", "rel": "bookmark"}], "addresses": {"private": [{"version": 4, "addr": "10.12.24.192"}, {"version": 4, "addr": "15.184.122.30"}]}, "tenant_id": "54336735645370", "image": {"id": "8867", "links": [{"href": "https://compute.systest.aw1.hpcloud.net/54336735645370/images/8867", "rel": "bookmark"}]}, "created": "2012-04-06T11:41:02Z", "uuid": "ac03d9c4-9ceb-4909-a902-739fa927b98e", "accessIPv4": "invalidipv4a99", "accessIPv6": "::babe:67.23.10.99", "key_name": null, "progress": 100, "flavor": {"id": "9", "links": [{"href": "https://compute.systest.aw1.hpcloud.net/54336735645370/flavors/9", "rel": "bookmark"}]}, "config_drive": "", "id": 135530, "metadata": {"meta": "HPCS-0"}}}

[Brian Waldon (bcwaldon)]

We currently don't do any validation on access ip values as the spec doesn't require it. It is intended for use solely by the client, so I don't think we should even care what's there.