OpenStack Compute (Nova)

xenapi poll_unconfirmed_resizes needs better error handling

Reported by Chris Behrens on 2012-04-02
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Medium
Chris Behrens

Bug Description

poll_unconfirmed_resizes() in xenapi will bail out of looping through all migrations if compute_api.confirm_resize() raises for any reason (most common reason I see is InstanceInvalidState raised).

It's possible that we're trying to confirm a resize of an instance in ERROR, etc.

Chris Behrens (cbehrens) on 2012-04-02
Changed in nova:
assignee: nobody → Chris Behrens (cbehrens)
status: New → Confirmed
Chris Behrens (cbehrens) on 2012-04-02
Changed in nova:
status: Confirmed → In Progress
importance: Undecided → Medium

Reviewed: https://review.openstack.org/6124
Committed: http://github.com/openstack/nova/commit/16b01aa96532d789dba189029764aad82ab6c362
Submitter: Jenkins
Branch: master

commit 16b01aa96532d789dba189029764aad82ab6c362
Author: Chris Behrens <email address hidden>
Date: Mon Apr 2 22:19:26 2012 +0000

    Auto-confirming resizes would bail on exceptions

    Fixes bug 971939

    Fixes a few things. If instance went to error, we should set the
    migration to error so we don't retry. Also, if we get any other
    exceptions when trying to confirm resizes, we should not bail out of the
    loop. Also: be nice to other greenthreads and yield on each iteration.

    Includes complete unit test for xenapi poll_unconfirmed_resizes which
    didn't exist prior to this patch.

    Change-Id: I6f7c1ccfd4be0f1497727d817130a821902d134d

Changed in nova:
status: In Progress → Fix Committed
Devin Carlen (devcamcar) on 2012-05-22
Changed in nova:
milestone: none → folsom-1
Thierry Carrez (ttx) on 2012-05-23
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2012-09-27
Changed in nova:
milestone: folsom-1 → 2012.2
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers