Can't delete volume snapshot in error state

[Anthony Young]

Steps to reproduce:

> run devstack # devstack uses a 2 gig volume group by default
> nova volume-create 2 # use up all 2 gigs
> nova volume-snapshot-create [volume_id] # this will fail, leaving a snapshot in an 'error' state
> nova delete [snapshot_id]

Expected:

I can delete the snapshot

Actual:

$ nova volume-snapshot-delete 9
ERROR: Invalid volume: must be available (HTTP 400)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/5985

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/6019

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/5985
Committed: http://github.com/openstack/nova/commit/46d65edcc948781aeea1d611735d81c2b29322f3
Submitter: Jenkins
Branch: master

commit 46d65edcc948781aeea1d611735d81c2b29322f3
Author: Anthony Young <email address hidden>
Date: Thu Mar 29 16:41:21 2012 -0700

    Allow snapshots in error state to be deleted.

     * Fixes bug 968682

    Change-Id: I37fd8e84e50b2f824f978eb7e3181ffb6ddde537

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/6019
Committed: http://github.com/openstack/nova/commit/e691eaf58b4c1ec4019982eb5b2604270c1ded09
Submitter: Jenkins
Branch: milestone-proposed

commit e691eaf58b4c1ec4019982eb5b2604270c1ded09
Author: Anthony Young <email address hidden>
Date: Thu Mar 29 16:41:21 2012 -0700

    Allow snapshots in error state to be deleted.

     * Fixes bug 968682

    Change-Id: I37fd8e84e50b2f824f978eb7e3181ffb6ddde537