NoopFirewallDriver results in infinite loop with libvirt

Bug #953781 reported by Isaku Yamahata
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Isaku Yamahata

Bug Description

 NoopFirewallDriver::instance_filter_exists must return True
 Otherwise, virt.libvirt.connection.ensure_filtering_rules_for_instance() results in infinite loop.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/5270

Changed in nova:
assignee: nobody → Isaku Yamahata (yamahata)
status: New → In Progress
Revision history for this message
Isaku Yamahata (yamahata) wrote :
tags: added: essex-rc-potential
Changed in nova:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/5270
Committed: http://github.com/openstack/nova/commit/7c50652a97fe7ebd74ce38572cbd9744c76b2f71
Submitter: Jenkins
Branch: master

commit 7c50652a97fe7ebd74ce38572cbd9744c76b2f71
Author: Isaku Yamahata <email address hidden>
Date: Mon Mar 5 16:21:41 2012 +0900

    virt/firewall: NoopFirewallDriver::instance_filter_exists must return True

    Otherwise, virt.libvirt.connection.ensure_filtering_rules_for_instance()
    results in infinite loop.
    And eliminate NullFirewallDriver as it's same to NoopFirewallDriver.
    This patch fixes bug 953781.

    Change-Id: I7936b3c69e9269041defd1ef7e5dda2de1f96dab

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → essex-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: essex-rc1 → 2012.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.