nova-manage fixed list Keyerror when fixed ip allocated to missing instance

[Dan Prince]

Getting the following error from 'nova-manage fixed list' when my DB has fixed ip's allocated to deleted instances.

network IP address hostname host
192.168.0.0/24 192.168.0.0 None None
192.168.0.0/24 192.168.0.1 None None
192.168.0.0/24 192.168.0.2 None None
Command failed, please check log for more info
2012-03-13 03:43:37 CRITICAL nova [req-bc37622d-6c0f-41fc-a27b-687fc726c7ab None None] 5L
(nova): TRACE: Traceback (most recent call last):
(nova): TRACE: File "/usr/bin/nova-manage", line 2203, in <module>
(nova): TRACE: main()
(nova): TRACE: File "/usr/bin/nova-manage", line 2190, in main
(nova): TRACE: fn(*fn_args, **fn_kwargs)
(nova): TRACE: File "/usr/bin/nova-manage", line 587, in list
(nova): TRACE: instance = instances_by_id[fixed_ip['instance_id']]
(nova): TRACE: KeyError: 5L
(nova): TRACE:

This state shouldn't happen.... (if it does there is something wrong with Nova) but it seems like nova-manage should handle it better.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/5264

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/5264
Committed: http://github.com/openstack/nova/commit/da23487487d442cffeb252236428abbda3f45746
Submitter: Jenkins
Branch: master

commit da23487487d442cffeb252236428abbda3f45746
Author: Dan Prince <email address hidden>
Date: Mon Mar 12 23:52:40 2012 -0400

    fixed list warn when ip allocated to missing inst.

    Update 'nova-manage fixed list' so it prints a warning if an IP
    is allocated to a deleted/missing instance.

    Fixes LP Bug #953685.

    Change-Id: I72b7ad2cb01e31cf9bb6cab904ab10d8769a3526