'Network' object has no attribute 'dhcp_server'

[Dan Prince]

Using the latest Nova Essex builds on Fedora 16...

I'm seeing the following exception in /var/log/nova/network.log when using FlatDHCP w/ linux_net:

2012-03-10 13:23:57 ERROR nova.rpc.amqp [-] Exception during message handling
(nova.rpc.amqp): TRACE: Traceback (most recent call last):
(nova.rpc.amqp): TRACE: File "/usr/lib/python2.7/site-packages/nova/rpc/amqp.py", line 252, in _process_data
(nova.rpc.amqp): TRACE: rval = node_func(context=ctxt, **node_args)
(nova.rpc.amqp): TRACE: File "/usr/lib/python2.7/site-packages/nova/network/manager.py", line 260, in wrapped
(nova.rpc.amqp): TRACE: return func(self, context, *args, **kwargs)
(nova.rpc.amqp): TRACE: File "/usr/lib/python2.7/site-packages/nova/network/manager.py", line 376, in deallocate_for_instance
(nova.rpc.amqp): TRACE: super(FloatingIP, self).deallocate_for_instance(context, **kwargs)
(nova.rpc.amqp): TRACE: File "/usr/lib/python2.7/site-packages/nova/network/manager.py", line 260, in wrapped
(nova.rpc.amqp): TRACE: return func(self, context, *args, **kwargs)
(nova.rpc.amqp): TRACE: File "/usr/lib/python2.7/site-packages/nova/network/manager.py", line 931, in deallocate_for_instance
(nova.rpc.amqp): TRACE: **kwargs)
(nova.rpc.amqp): TRACE: File "/usr/lib/python2.7/site-packages/nova/network/manager.py", line 250, in deallocate_fixed_ip
(nova.rpc.amqp): TRACE: address)
(nova.rpc.amqp): TRACE: File "/usr/lib/python2.7/site-packages/nova/network/manager.py", line 1213, in deallocate_fixed_ip
(nova.rpc.amqp): TRACE: self._teardown_network_on_host(context, network)
(nova.rpc.amqp): TRACE: File "/usr/lib/python2.7/site-packages/nova/network/manager.py", line 1680, in _teardown_network_on_host
(nova.rpc.amqp): TRACE: self.driver.update_dhcp(context, dev, network)
(nova.rpc.amqp): TRACE: File "/usr/lib/python2.7/site-packages/nova/network/linux_net.py", line 670, in update_dhcp
(nova.rpc.amqp): TRACE: restart_dhcp(context, dev, network_ref)
(nova.rpc.amqp): TRACE: File "/usr/lib/python2.7/site-packages/nova/utils.py", line 903, in inner
(nova.rpc.amqp): TRACE: retval = f(*args, **kwargs)
(nova.rpc.amqp): TRACE: File "/usr/lib/python2.7/site-packages/nova/network/linux_net.py", line 730, in restart_dhcp
(nova.rpc.amqp): TRACE: '--listen-address=%s' % network_ref['dhcp_server'],
(nova.rpc.amqp): TRACE: File "/usr/lib/python2.7/site-packages/nova/db/sqlalchemy/models.py", line 75, in __getitem__
(nova.rpc.amqp): TRACE: return getattr(self, key)
(nova.rpc.amqp): TRACE: AttributeError: 'Network' object has no attribute 'dhcp_server'

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/5198

[Dan Prince (dan-prince)]

I suspect this issue is responsible for a rather large number of false negatives I've been seeing on SmokeStack this week running Torpedo, Smoke Tests, and Tempest...

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/5198
Committed: http://github.com/openstack/nova/commit/a44f4c779f4c8beda98075cdb63582a15613a808
Submitter: Jenkins
Branch: master

commit a44f4c779f4c8beda98075cdb63582a15613a808
Author: Dan Prince <email address hidden>
Date: Sat Mar 10 12:14:53 2012 -0500

    Set 'dhcp_server' in _teardown_network_on_host.

    Update _teardown_network_on_host so that it sets 'dhcp_server'
    on network objects for compatability when using flat dhcp with
    linux_net.

    Fixes LP bug #951642. ('Network' object has no attribute 'dhcp_server')

    Change-Id: I53ab99155ea6e4163c9eb0b28b765f962f99a2b1