OpenStack Compute (Nova)

RequestContext removal of strategy keyword arg breaks upgrades

Reported by Chris Behrens on 2012-03-08
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Medium
Chris Behrens

Bug Description

http://paste.openstack.org/show/7364/

Unfortunately this was extremely difficult to track down... as it appears that exceptions that happen in rpc's ProxyCallback __call__ get completely eaten with nothing logged. It also seems to stop further consumes from the rabbit queue.

Essentially what happened here is that there was some old messages in the rabbit queue that had the previous version of RequestContext encoded. Ie, 'strategy' was in the message. Due to how RequestContext.from_dict() creates a class instance by doing cls(**kwargs)... this traceback occurs.

Chris Behrens (cbehrens) on 2012-03-08
description: updated
Changed in nova:
importance: Undecided → Medium
status: New → In Progress
assignee: nobody → Chris Behrens (cbehrens)

Reviewed: https://review.openstack.org/5072
Committed: http://github.com/openstack/nova/commit/eba95d1e42992056edf6f0d6f84e8e230f331cd7
Submitter: Jenkins
Branch: master

commit eba95d1e42992056edf6f0d6f84e8e230f331cd7
Author: Chris Behrens <email address hidden>
Date: Thu Mar 8 00:07:30 2012 -0800

    Add kwargs to RequestContext __init__

    Fixes bug 949726

    This allows processing of rpc messages that contain older versions of
    RequestContext to not raise an exception.

    Change-Id: I4891a44280fcb8accf0cef1c00c1123029abcc96

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2012-03-20
Changed in nova:
milestone: none → essex-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2012-04-05
Changed in nova:
milestone: essex-rc1 → 2012.1
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers