TestMigrations does not work with latest migrate and sqlaclhemy

[Jason Kölker]

Brand new virtual env:

======================================================================
ERROR: test_walk_versions (nova.tests.test_migrations.TestMigrations)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/jkoelker/openstack/nova/nova/tests/test_migrations.py", line 167, in test_walk_versions
    self._walk_versions(engine, self.snake_walk)
  File "/home/jkoelker/openstack/nova/nova/tests/test_migrations.py", line 179, in _walk_versions
    TestMigrations.REPOSITORY))
  File "<string>", line 2, in db_version
  File "/home/jkoelker/.virtualenvs/nova/lib/python2.7/site-packages/migrate/versioning/util/__init__.py", line 159, in with_engine
    return f(*a, **kw)
  File "/home/jkoelker/.virtualenvs/nova/lib/python2.7/site-packages/migrate/versioning/api.py", line 148, in db_version
    schema = ControlledSchema(engine, repository)
  File "/home/jkoelker/.virtualenvs/nova/lib/python2.7/site-packages/migrate/versioning/schema.py", line 32, in __init__
    self.load()
  File "/home/jkoelker/.virtualenvs/nova/lib/python2.7/site-packages/migrate/versioning/schema.py", line 44, in load
    self.table = Table(tname, self.meta, autoload=True)
  File "/home/jkoelker/.virtualenvs/nova/lib/python2.7/site-packages/sqlalchemy/schema.py", line 303, in __new__
    table._init(name, metadata, *args, **kw)
  File "/home/jkoelker/.virtualenvs/nova/lib/python2.7/site-packages/sqlalchemy/schema.py", line 366, in _init
    self._autoload(metadata, autoload_with, include_columns)
  File "/home/jkoelker/.virtualenvs/nova/lib/python2.7/site-packages/sqlalchemy/schema.py", line 390, in _autoload
    self, include_columns, exclude_columns
  File "/home/jkoelker/.virtualenvs/nova/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 2276, in run_callable
    return conn.run_callable(callable_, *args, **kwargs)
  File "/home/jkoelker/.virtualenvs/nova/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 1900, in run_callable
    return callable_(self, *args, **kwargs)
  File "/home/jkoelker/.virtualenvs/nova/lib/python2.7/site-packages/sqlalchemy/engine/default.py", line 259, in reflecttable
    return insp.reflecttable(table, include_columns, exclude_columns)
  File "/home/jkoelker/.virtualenvs/nova/lib/python2.7/site-packages/sqlalchemy/engine/reflection.py", line 412, in reflecttable
    raise exc.NoSuchTableError(table.name)
DatabaseNotControlledError: migrate_version

[Jason Kölker (jason-koelker)]

It appears that its creating one sqlite memory db applying the version to it, and then testing a new sqlite memory db for version control.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/4511

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/4511
Committed: http://github.com/openstack/nova/commit/a7df90089557516a82c0ba8f7368cdd541099059
Submitter: Jenkins
Branch: master

commit a7df90089557516a82c0ba8f7368cdd541099059
Author: Jason Kölker <email address hidden>
Date: Fri Feb 24 10:10:21 2012 -0600

    Monkey patch migrate < 0.7.3

    * Works around migrate issue 72 [1] by monkey patching migrate prior
      to import.
    * Removes previous workaround
    * Refactor test config to work under nosetests directly
    * Fixes LP940407

    1: https://code.google.com/p/sqlalchemy-migrate/issues/detail?id=72

    Change-Id: I219e4cecf8bb2e34ae238ac270428f496378ee61