openstack api allows deletion of in-use security group

[Anthony Young]

ec2 now
(or soon will) prevent users from deleting "in-use" security groups: https://review.openstack.org/#change,4154

There is no equivalent protection in the openstack api.

Steps to reproduce:

> nova boot --security_groups=foo ...
> nova secgroup-delete foo

Expected:

Error "in-use"

Actual:

Deletion of secgroup

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/4457

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/4457
Committed: http://github.com/openstack/nova/commit/f006c920e0dc3d3465b0af27b0154aeee3fad373
Submitter: Jenkins
Branch: master

commit f006c920e0dc3d3465b0af27b0154aeee3fad373
Author: Russell Bryant <email address hidden>
Date: Thu Feb 23 14:00:42 2012 -0500

    Don't delete security group in use from OS API.

    Fix bug 938853.

    This patch adds a check to the OpenStack API so that a security group
    still in use can not be deleted. This same check just recently went in
    for the EC2 API.

    Change-Id: I75dc47c5f5d227b94c45ba8a0f00c37bd63f09fc