OpenStack Compute (Nova)

security_group name is an XML element when creating a server, an attribute everywhere else

Reported by justinsb on 2012-02-16
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Undecided
justinsb

Bug Description

When creating a server, the security group names must be specified as an element. Everywhere else, the name is an attribute. This is painful.

I'm proposing a fix that checks for an attribute first on server create, but then falls back to an element so any XML clients will continue to work. Eventually I think we'll want to deprecate the element fallback.

I've already written and proposed the patch, but I wanted to link it to a bug report:
https://review.openstack.org/#change,4232

Changed in nova:
status: New → In Progress
Changed in nova:
assignee: nobody → justinsb (justin-fathomdb)

Reviewed: https://review.openstack.org/4232
Committed: http://github.com/openstack/nova/commit/6a951c77adf6d513a434bf65d46e3a0745b750f7
Submitter: Jenkins
Branch: master

commit 6a951c77adf6d513a434bf65d46e3a0745b750f7
Author: Justin Santa Barbara <email address hidden>
Date: Thu Feb 16 00:13:41 2012 -0800

    The security_group name should be an XML attribute

    It is everywhere apart from in servers.py. We have to be backwards
    compatible, so we check the attribute first, and then check the element.

    Bug #933785

    Change-Id: I66b96376043e665a026eff5c33aa0731a81730cc

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2012-02-29
Changed in nova:
milestone: none → essex-4
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2012-04-05
Changed in nova:
milestone: essex-4 → 2012.1
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers