OpenStack Compute (nova)

run_tests.sh (-x | --stop) is broken

Bug #931608 reported by Alex Meade
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Joe Gordon
OpenStack Compute (nova) 2012.1 "essex"

Bug Description

A recent change must have broken -x for run_tests.sh. When running run_tests.sh -x, it just ends execution instead of going to the first test failure.

Alex Meade (alex-meade)
Changed in nova:
assignee: nobody → Alex Meade (alex-meade)
status: New → In Progress
Alex Meade (alex-meade)
Changed in nova:
assignee: Alex Meade (alex-meade) → nobody
assignee: nobody → Titan (rackspace-titan)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/4077

Changed in nova:
assignee: Titan (rackspace-titan) → Alex Meade (alex-meade)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/4077
Committed: http://github.com/openstack/nova/commit/979c999464975f869b9ee05792e31c784aaf08f4
Submitter: Jenkins
Branch: master

commit 979c999464975f869b9ee05792e31c784aaf08f4
Author: Alex Meade <email address hidden>
Date: Mon Feb 13 20:00:11 2012 +0000

    Adding (-x | --stop) option back to runner.py

    fixes bug 931608

    Change-Id: I355a3bba38367c820a0eddc006ef480e5134b317

Changed in nova:
status: In Progress → Fix Committed
Revision history for this message
Joe Gordon (jogo) wrote :

The fix appears to not work completely. Tests don't stop after first fail.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/4169

Changed in nova:
assignee: Alex Meade (alex-meade) → Joe Gordon (joe-gordon0)
status: Fix Committed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/4169
Committed: http://github.com/openstack/nova/commit/6cb1658459d7906d81882c29f22d7d1e5ba22c69
Submitter: Jenkins
Branch: master

commit 6cb1658459d7906d81882c29f22d7d1e5ba22c69
Author: Joe Gordon <email address hidden>
Date: Tue Feb 14 15:38:22 2012 -0800

    Actual fix for bug 931608.

    -x --stop is a nose flag
    Provide short term solution to deal with '--hide-elapsed'

    Can be tested by adding a assertTrue(False) in a test and running
    ./run_tests.sh -x

    Change-Id: I7357e7cdaa3d6370ed111d6209917a833d084db3

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → essex-4
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: essex-4 → 2012.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.