OpenStack Compute (Nova)

hard coded database name in 077_convert_to_utf8.py

Reported by Hengqing Hu on 2012-02-12
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Undecided
Adam Gandelman

Bug Description

hard coded database name in 077_convert_to_utf8.py

hard coded database name:
         migrate_engine.execute(
           "ALTER DATABASE nova DEFAULT CHARACTER SET utf8")

this will be fixed in the solution of bug/854905

Hengqing Hu (hudayou) wrote :

solution is as below:

+ "ALTER DATABASE %s DEFAULT CHARACTER SET utf8" %
+ migrate_engine.url.database)

Changed in nova:
assignee: nobody → Hengqing Hu (hudayou)
status: New → In Progress
Changed in nova:
assignee: Hengqing Hu (hudayou) → Adam Gandelman (gandelman-a)

Reviewed: https://review.openstack.org/4149
Committed: http://github.com/openstack/nova/commit/516582b62d785d25044b0f852eb7e42a2b22558e
Submitter: Jenkins
Branch: master

commit 516582b62d785d25044b0f852eb7e42a2b22558e
Author: Adam Gandelman <email address hidden>
Date: Tue Feb 14 10:40:29 2012 -0800

    077_convert_to_utf8: Convert *all* FK tables early

    The original migration only takes care of migrating the instances
    table before all others. It turns out, when using MySQL with InnoDB
    by default, there are many other tables with FKs that need to be converted
    early on as well (see bug description for schema diagram).

    Fixes bug 931602

    Update: Convert all tables in a predefined order from within the same
    execution.

    Update: Avoid hard-coding database, fixes bug 930863

    Update: Fix pep8 spacing

    Change-Id: Ideb619eecef2ad067bda5c26612f761674dee924

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2012-02-29
Changed in nova:
milestone: none → essex-4
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2012-04-05
Changed in nova:
milestone: essex-4 → 2012.1
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers