compile_diagnostics in xenapi erronously catch XenAPI.Failure

[Armando Migliaccio]

If I have a webserver on my local machine, this test fails because get_rrd is not stubbed out and host is 127.0.0.1.

Besides, test_diagnostics is not very strong as it only checks that the vmops.get_diagnostics does no throw up. It'd be better if it tested that it worked as it's meant to.

This is on Nova trunk+some bits.

[Armando Migliaccio (armando-migliaccio)]

It turns out this bug is not exactly what I had initially thought, however I found another problem with compile_diagnostics, which tries to catch XenAPI.Failures on xml parsing. That's clearly not going to work. Fix coming shortly.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/3964

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/3966

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/3966
Committed: http://github.com/openstack/nova/commit/8297a1bed0b00447bd01a4501ab9eac88a5865e3
Submitter: Jenkins
Branch: master

commit 8297a1bed0b00447bd01a4501ab9eac88a5865e3
Author: Armando Migliaccio <email address hidden>
Date: Thu Feb 9 15:53:50 2012 +0000

    bug 929462: compile_diagnostics in xenapi erronously catch XenAPI.Failure

    ensure we catch the right exception. Plus turn test_diagnostics into a
    more thorough unit test.

    Change-Id: I1aae28b9b3b942f08e419cd9cfa48dea003e96d9