impl_qpid and impl_kombu can step on each other's connection pool
Bug #928996 reported by
Russell Bryant
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| OpenStack Compute (nova) |
Fix Released
|
Medium
|
Russell Bryant | ||
Bug Description
nova.rpc.impl_kombu and nova.rpc.impl_qpid both share nova.rpc.amqp. There is a connection pool that gets created in nova.rpc.amqp. This is usually fine, but causes problems if both drivers get loaded into the same Python instance (such as when running tests). The connection pool should be moved to impl_kombu and impl_qpid.
| Changed in nova: | |
| assignee: | nobody → Russell Bryant (russellb) |
| importance: | Undecided → Medium |
| milestone: | none → essex-4 |
| Changed in nova: | |
| status: | New → In Progress |
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Fix merged to nova (master) | #1 |
| Changed in nova: | |
| status: | In Progress → Fix Committed |
| Changed in nova: | |
| status: | Fix Committed → Fix Released |
| Changed in nova: | |
| milestone: | essex-4 → 2012.1 |
To post a comment you must log in.
Reviewed: https:/
Committed: http://
Submitter: Jenkins
Branch: master
commit e0efd7551d0d4e1
Author: Russell Bryant <email address hidden>
Date: Tue Feb 7 22:31:27 2012 -0500
Move connection pool back into impl_kombu/qpid.
Fix bug 928996.
This patch moves the creation of the connection pool from nova.rpc.amqp
back into nova.rpc.impl_kombu and nova.rpc.impl_qpid. The pool now gets
passed into nova.rpc.amqp using arguments as needed.
The previous method worked fine unless both rpc implementations got
loaded into the same Python instance. In that case, whichever one got
loaded 2nd had control over what type of connections nova.rpc.amqp would
create. With these changes in place, this conflict between impl_kombu
and impl_qpid is resolved.
Change-Id: I72bc0c95bfc04c