Exception in finish_resize() will leave instance stuck in RESIZE

[Johannes Erdfelt]

An exception in nova.compute.manager:finish_resize() will leave the instance stuck in ERROR. There is some handling of exceptions (but only wrapping the driver finish_resize() method) where as exceptions can happen elsewhere (like _get_image_meta that I just saw).

The existing exception handling should probably cover the entire function and not just the stuff that calls the driver.

[Johannes Erdfelt (johannes.erdfelt)]

As well as any exceptions that occur in _get_instance_nw_info() during finish_resize() (as I just saw in some testing).

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/3908

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/3908
Committed: http://github.com/openstack/nova/commit/5d85be45a53d0a065622e84de30c65c1ce75faca
Submitter: Jenkins
Branch: master

commit 5d85be45a53d0a065622e84de30c65c1ce75faca
Author: Johannes Erdfelt <email address hidden>
Date: Wed Feb 8 19:07:43 2012 +0000

    Handle service failures during finish_resize gracefully

    Fixes bug 928474

    If exceptions occur in the network or image service during finish_resize(),
    the instance can be left in RESIZE state. This change will ensure those
    exceptions will move the instance to ERROR as well.

    Change-Id: I638db27da27310ccd55d52453c3aadaa41634040