firewall: setup_basic_filtering() and prepare_instance_filter() can be merged

Bug #925456 reported by Mark McLoughlin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Invalid
Wishlist
Unassigned

Bug Description

Each of the 4 places where setup_basic_filtering() is called, we immediately call prepare_instance_filter() right after it

The split doesn't look useful to me, we can just merge the two calls

Changed in nova:
assignee: nobody → Ed Cranford (ed--cranford)
status: New → In Progress
Revision history for this message
Thierry Carrez (ttx) wrote :

Obviously not in progress...

Changed in nova:
assignee: Ed Cranford (ed--cranford) → nobody
status: In Progress → Confirmed
Revision history for this message
Alaa Mohammed Agwa (agwatic) wrote :

This is my patch for it

Changed in nova:
assignee: nobody → Alaa Mohammed Agwa (agwatic)
Changed in nova:
status: Confirmed → Fix Committed
Changed in nova:
status: Fix Committed → In Progress
Revision history for this message
Mohammed Naser (mnaser) wrote :

There are multiple references in nova.virt.libvirt.driver where prepare_instance_filter is not called right after. Is this bug still valid or should it be set as invalid?

https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L1400

Changed in nova:
assignee: Alaa Mohammed Agwa (agwatic) → Mohammed Naser (mnaser)
Revision history for this message
Sean Dague (sdague) wrote :

A current look at the nova source code is that in the libvirt tree this isn't true. only 2 of 4 calls use both. So marking as invalid

Changed in nova:
status: In Progress → Invalid
assignee: Mohammed Naser (mnaser) → nobody
importance: Low → Wishlist
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.