admin_password is not set if no agent_build record exists

Bug #925237 reported by Dan Prince
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
High
Dan Prince

Bug Description

As of commit a7004dee703908eaa51bb0c3765a0d877afdd2a1 I now get the following failures when running Torpedo w/ XenServer:

  1) Error:
test_001_create_server(Torpedo::Compute::Servers):
RuntimeError: Timeout trying to ssh to server: 192.168.0.2
    /var/lib/gems/1.8/gems/torpedo-1.0.13/lib/torpedo/compute/servers.rb:75:in `ssh_test'
    /var/lib/gems/1.8/gems/torpedo-1.0.13/lib/torpedo/compute/servers.rb:128:in `check_server'
    /var/lib/gems/1.8/gems/torpedo-1.0.13/lib/torpedo/compute/servers.rb:167:in `test_001_create_server'

---

The root cause seems to be that we require an agent_build record to exist before we attempt to configure the admin password on an instance.

The version check we added in a7004dee703908eaa51bb0c3765a0d877afdd2a1 is great. I do not however see any reason to require an agent_build record to exist in the database before we try to inject a password.

Revision history for this message
Dan Prince (dan-prince) wrote :

The original ticket was here:

https://bugs.launchpad.net/nova/+bug/923865

Dan Prince (dan-prince)
Changed in nova:
assignee: nobody → Dan Prince (dan-prince)
status: New → In Progress
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/3649

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/3649
Committed: http://github.com/openstack/nova/commit/233f5a738f39bae9b815383cb0ba2f3c207ae813
Submitter: Jenkins
Branch: master

commit 233f5a738f39bae9b815383cb0ba2f3c207ae813
Author: Dan Prince <email address hidden>
Date: Wed Feb 1 20:50:51 2012 -0500

    Fix admin password skip check.

    Skip admin password configuration only if the agent 'version' is
    empty. Previously both the 'version' and 'agent_build' were
    required to be set.

    As the 'agent_build' table is primarily used for upgrades
    there should be no requirement that a record exist in order
    to configure admin passwords.

    Fixes LP Bug #925237.

    Change-Id: Ie4530a30ed02f3d49a07037e9d1cc52ef0af1dd4

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → essex-4
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: essex-4 → 2012.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.