OpenStack Compute (Nova)

connection_type and firewall_driver flags mismatch

Reported by Armando Migliaccio on 2012-01-31
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Undecided
Armando Migliaccio

Bug Description

Currently connection_type is set to None, so having firewall_driver to default to nova.virt.libvirt.firewall.IptablesFirewallDriver does not make sense. Instead it should be set to nova.virt.firewall.IptablesFirewallDriver.

This means that devstack has to explicitly set the firewall driver in the libvirt case, as it does for XenServer.

Changed in nova:
status: New → Confirmed
assignee: nobody → Armando Migliaccio (armando-migliaccio)

Fix proposed to branch: master
Review: https://review.openstack.org/3578

Changed in nova:
status: Confirmed → In Progress

Reviewed: https://review.openstack.org/3578
Committed: http://github.com/openstack/nova/commit/659342feff6a127a852b10d883af9c9c20db6a31
Submitter: Jenkins
Branch: master

commit 659342feff6a127a852b10d883af9c9c20db6a31
Author: Armando Migliaccio <email address hidden>
Date: Tue Jan 31 15:20:27 2012 +0000

    bug 924266: connection_type and firewall_driver flags mismatch

    If connection_type is None, the default firewall driver should not
    be nova.virt.libvirt.firewall.IptablesFirewallDriver; it should
    either be None or the base one.

    If this fix gets through, devstack needs to be fixed accordingly.
    See review below for details.

    https://review.openstack.org/#change,3576

    Change-Id: I58dabc50be2d5cdcd509b2ac89a5bd0f78251bd0

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2012-02-29
Changed in nova:
milestone: none → essex-4
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2012-04-05
Changed in nova:
milestone: essex-4 → 2012.1
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers