XenAPI get_all_bw_usage using name-label to ingore control domain

Bug #920588 reported by Rick Harris on 2012-01-23
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Rick Harris

Bug Description

This method works (for now), but the vm_record contains an attribute called 'is_control_domain' which would be better to use for this purpose.

if name.startswith('Control domain'):

should be

if vm_rec['is_control_domain']:

While we're at it, we probably want to ignore template VMs as well so, it probably should be:

# see VMHelper.list_vms
if vm_rec['is_control_domain'] or vm_rec['is_a_template']:

Changed in nova:
importance: Undecided → Low
Brian Waldon (bcwaldon) on 2012-01-26
Changed in nova:
status: New → Triaged
Changed in nova:
assignee: nobody → Rick Harris (rconradharris)

Fix proposed to branch: master
Review: https://review.openstack.org/3639

Changed in nova:
status: Triaged → In Progress

Reviewed: https://review.openstack.org/3639
Committed: http://github.com/openstack/nova/commit/67a419de2d16b83a4ab53431b1ed3fb83abd9eac
Submitter: Jenkins
Branch: master

commit 67a419de2d16b83a4ab53431b1ed3fb83abd9eac
Author: Rick Harris <email address hidden>
Date: Wed Feb 1 21:41:38 2012 +0000

    Improve dom0 and template VM avoidance.

    Fixes bug 920588

    Change-Id: Ia19f6e99faceba75af509699a5601f87218671ed

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2012-02-29
Changed in nova:
milestone: none → essex-4
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2012-04-05
Changed in nova:
milestone: essex-4 → 2012.1
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers