error message of "nova" after trying to create a keypair with the name of an existing keypair should be something useful

[Christian Berendt]

i think the error message should be "there is already an existing key with the name 'foobar'" or somethink like that.

example:

stack@stack1:~$ nova --username admin --password testing keypair-list
+--------+-------------------------------------------------+
| Name | Fingerprint |
+--------+-------------------------------------------------+
| foobar | f8:3e:13:94:f7:e0:f0:7b:6e:2d:45:18:ce:56:be:fa |
+--------+-------------------------------------------------+

stack@stack1:~$ nova keypair-add foobar
The server has either erred or is incapable of performing the requested operation. (HTTP 500)

[Christian Berendt (berendt)]

exception on nova-api is correct:

(nova.api.openstack): TRACE: raise exception.KeyPairExists(key_name=name)
(nova.api.openstack): TRACE: KeyPairExists: Key pair foobar already exists.

nova receives a unspecific error:

RESP:{'date': 'Thu, 26 Jan 2012 22:25:46 GMT', 'status': '500', 'content-length': '128', 'content-type': 'application/json; charset=UTF-8'} {"computeFault": {"message": "The server has either erred or is incapable of performing the requested operation.", "code": 500}}

"computeFault" is defined in nova/api/openstack/wsgi.py in class Fault, a wrapper for webob.exc.HTTPException.

The wrapper receives as exception a WebOb.webob.exc.HTTPServerError object and not the KeyPairExists exception.

This is because the class FaultWrapper in nova/api/openstack/__init__.py simply catchs all exceptions and afterward it returns a webob.exc.HTTPInternalServerError() exception for every case.

I would prefer setting the explanation for the HTTPException more specific --> exc.explanation = unicode(ex)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/3487

[Christian Berendt (berendt)]

proposed change in the fault wrapper of wsgi was rejected. someone else has to take a look.