OpenStack Compute (Nova)

Missing scripts in 2011.3.1 (no distutils-extra in venv, now used to build tarballs)

Reported by Mark McLoughlin on 2012-01-17
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Critical
Mark McLoughlin
Diablo
Critical
Mark McLoughlin

Bug Description

2011.3 contained:

   bin/clear_rabbit_queues
   bin/instance-usage-audit
   bin/nova-api-ec2
   bin/nova-api-os
   bin/nova-vsa

but they're missing from http://nova.openstack.org/tarballs/nova-2011.3.1~20120117.10814.tar.gz

Mark McLoughlin (markmc) on 2012-01-17
description: updated
Mark McLoughlin (markmc) wrote :

These weren't listed in setup.py scripts for 2011.3 either

I'm guessing distutils-extra pulled them in for 2011.3 but the tarball isn't being built with that any more

nova-api-ec2 and nova-api-os are/were explicitly listed on master, so it makes sense to add them

clear_rabbit_queues, instance-usage-audit and nova-vsa aren't in the 2012.1 tarballs either, so I'm less sure about them

Thierry Carrez (ttx) wrote :

Adding an openstack-ci bug task, in case the missing distutils-extra (or the idea to run setup.py sdist from the venv) has extra reasoning behind it.

summary: - Missing scripts from 2011.3.1 binaries
+ Missing scripts in 2011.3.1 (no distutils-extra in venv, now used to
+ build tarballs)
Mark McLoughlin (markmc) on 2012-01-17
Changed in nova:
milestone: 2011.3.1 → essex-3

Fix proposed to branch: master
Review: https://review.openstack.org/3105

Changed in nova:
status: Confirmed → In Progress

Reviewed: https://review.openstack.org/3105
Committed: http://github.com/openstack/nova/commit/d72109e7114724de668de24800829b07e0d3fe7e
Submitter: Jenkins
Branch: master

commit d72109e7114724de668de24800829b07e0d3fe7e
Author: Mark McLoughlin <email address hidden>
Date: Tue Jan 17 15:07:58 2012 +0000

    Add missing scripts to setup.py (lp#917676)

    If distutils-extra is installed, all scripts are automatically included
    in the tarball. We should explicitly include them in setup.py to avoid
    confusion.

    As an example, the 2011.3 tarballs appear to have been generated with
    distutils-extra but the 2011.3.1/2012.1 tarballs are now being
    generated in a venv. So, these newer tarballs are missing scripts which
    were included in 2011.3.

    Change-Id: I2a85418b84b93e041f6c7d31833b09acdcb29daa

Changed in nova:
status: In Progress → Fix Committed

Reviewed: https://review.openstack.org/3106
Committed: http://github.com/openstack/nova/commit/c7a9d522a344d6ac57774d68e76be3510699267c
Submitter: Jenkins
Branch: stable/diablo

commit c7a9d522a344d6ac57774d68e76be3510699267c
Author: Mark McLoughlin <email address hidden>
Date: Tue Jan 17 15:07:58 2012 +0000

    Add missing scripts to setup.py (lp#917676)

    If distutils-extra is installed, all scripts are automatically included
    in the tarball. We should explicitly include them in setup.py to avoid
    confusion.

    As an example, the 2011.3 tarballs appear to have been generated with
    distutils-extra but the 2011.3.1/2012.1 tarballs are now being
    generated in a venv. So, these newer tarballs are missing scripts which
    were included in 2011.3.

    (cherry picked from commit d72109e7114724de668de24800829b07e0d3fe7e)

    Change-Id: I2a85418b84b93e041f6c7d31833b09acdcb29daa

tags: added: in-stable-diablo
Thierry Carrez (ttx) on 2012-01-25
Changed in nova:
status: Fix Committed → Fix Released
Monty Taylor (mordred) on 2012-01-26
no longer affects: openstack-ci
Thierry Carrez (ttx) on 2012-04-05
Changed in nova:
milestone: essex-3 → 2012.1
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers